1674273 - Crash in [@ HyperTextIterator::NormalizeForward]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

macOS-only crash which affects Firefox 82+. The files in the stack saw a bunch of changes in the 82 cycle (bug 1660290 etc.)

Crash report: https://crash-stats.mozilla.org/report/index/450517f2-7e14-4aa3-9e57-f1f530200924

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0 XUL HyperTextIterator::NormalizeForward accessible/mac/HyperTextAccessibleWrap.mm:66
1 XUL HyperTextIterator::Next accessible/mac/HyperTextAccessibleWrap.mm:179
2 XUL mozilla::a11y::HyperTextAccessibleWrap::TextForRange accessible/mac/HyperTextAccessibleWrap.mm:200
3 XUL mozilla::a11y::GeckoTextMarkerRange::Text const accessible/mac/GeckoTextMarker.mm:336
4 XUL -[MOXTextMarkerDelegate moxStringForTextMarkerRange:] accessible/mac/MOXTextMarkerDelegate.mm:122
5 XUL -[MOXTextMarkerDelegate moxLengthForTextMarkerRange:] accessible/mac/MOXTextMarkerDelegate.mm:126
6 XUL -[MOXAccessibleBase accessibilityAttributeValue:forParameter:] accessible/mac/MOXAccessibleBase.mm:326
7 AppKit ___NSAccessibilityEntryPointValueForAttributeWithParameter_block_invoke.821 
8 AppKit NSAccessibilityPerformEntryPointObject 
9 AppKit NSAccessibilityEntryPointValueForAttributeWithParameter 

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1674273 - Consider a hyperlink with no hypertext parent as a root. r?morgan!

Comment 3

[⚜️Québec🇨🇦Canada🍁]

I don't use voiceover support.

Any examples of other assistive features on macOS?
So, we can narrow down the causes:)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efff416839c9
Consider a hyperlink with no hypertext parent as a root. r=morgan

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/efff416839c9

Comment 6

[⚜️Québec🇨🇦Canada🍁]

(In reply to ⚜️Québec🇨🇦Canada🍁 from comment #3)

I don't use voiceover support.

Any examples of other assistive features on macOS?
So, we can narrow down the causes:)

I don't use accessibility services and have the "Prevent accessibility services from accessing your browser" option checked as always until Firefox removed this option recently...

Here's an old screenshot:
https://techdows.com/wp-content/uploads/2017/09/Firefox-57-disable-accessbility-services.png

Comment 7

[⚜️Québec🇨🇦Canada🍁]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efff416839c9
Consider a hyperlink with no hypertext parent as a root. r=morgan

Fx 83.0 crashed...
https://crash-stats.mozilla.org/report/index/e35af05a-8d1b-4caa-9bc6-9dbeb0201117#tab-bugzilla