1674307 - No focusin/focusout checkboxes in the "Event Listener Breakpoints"

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The "Event Listener Breakpoints" do not have checkboxes for focusin event and focusout event which were introduced by bug687787. Perhaps, they should be around the checkboxes for focus and blur under "Control" group.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Agreed, thanks for the report!

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Bomsy, could this be a first good bug, perhaps you could mentor it?

Honza

Comment 3

[Hubert Boma Manilla (:bomsy)]

Sure! Thanks Honza!

Comment 4

[sanjana2000d]

Hi, I would like to work on this issue if it is still open. How can I get started?

Comment 5

[Hubert Boma Manilla (:bomsy)]

Hi sanjana2000d,
Thanks for your interest. Sure you can work on it.

If you have not already, You can follow https://firefox-source-docs.mozilla.org/devtools/index.html to get started.

Once you are all setup
To fix the issue we probably want to a items for the focusin and focusout events below this line https://searchfox.org/mozilla-central/rev/bfbacfb6a4efd98247e83d3305e912ca4f7e106a/devtools/server/actors/utils/event-breakpoints.js#127

Comment 6

[yogitab2798]

Hey Hubert,
Is this issue still up for grabs? If it is, I'd love to give it a shot.

Comment 7

[Hubert Boma Manilla (:bomsy)]

Hey yogitab2798 ,
Sure if sanjana2000d is not working on it.

sanjana2000d,
How is this going ? Are you still interested in working on it?

Comment 8

[yogitab2798]

Hey Hubert, can you also share me the link of Mozilla channel?

Comment 9

[yogitab2798]

Hey Hubert, there has been no response from sanjana2000d since 2 days and I have cloned and built Mozilla. Will you help me get started on this bug?

Comment 10

[Hubert Boma Manilla (:bomsy)]

Hey yogitab2798,
Sure i'll assign to you. If you have setup firefox. See the second part of Comment 5 on how to fix.

Hi sanjana2000d,
I'm re-assigning it to yogitab2798, if you are interested we can find something else for you.

Comment 11

[yogitab2798]

Alright, thanks! I will update you with a PR soon

Comment 12

[yogitab2798]

Attachment: Bug 1674307 - Add focusin and focusout checkboxes in Event Listener Breakpoints r=bomsy

Comment 13

[yogitab2798]

Attachment: Bug 1674307 - Add focusout checkbox in Event Listener Breakpoints r=bomsy

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a2e24377ae3
Add focusin and focusout checkboxes in Event Listener Breakpoints r=bomsy

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7a2e24377ae3