Closed Bug 1674307 Opened 7 months ago Closed 3 months ago

No focusin/focusout checkboxes in the "Event Listener Breakpoints"

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: masayuki, Assigned: yogitab2798, Mentored, NeedInfo)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

Bug 1674307 - Add focusin and focusout checkboxes in Event Listener Breakpoints r=bomsy
48 bytes, text/x-phabricator-request
Details | Review

The "Event Listener Breakpoints" do not have checkboxes for focusin event and focusout event which were introduced by bug687787. Perhaps, they should be around the checkboxes for focus and blur under "Control" group.

Agreed, thanks for the report!

Honza

Blocks: dbg-event-bps
Severity: -- → S3
Priority: -- → P3

Bomsy, could this be a first good bug, perhaps you could mentor it?

Honza

Flags: needinfo?(hmanilla)

Sure! Thanks Honza!

Mentor: hmanilla
Flags: needinfo?(hmanilla)
Keywords: good-first-bug

Hi, I would like to work on this issue if it is still open. How can I get started?

Hi sanjana2000d,
Thanks for your interest. Sure you can work on it.

If you have not already, You can follow https://firefox-source-docs.mozilla.org/devtools/index.html to get started.

Once you are all setup
To fix the issue we probably want to a items for the focusin and focusout events below this line https://searchfox.org/mozilla-central/rev/bfbacfb6a4efd98247e83d3305e912ca4f7e106a/devtools/server/actors/utils/event-breakpoints.js#127

Assignee: nobody → sanjana2000d

Hey Hubert,
Is this issue still up for grabs? If it is, I'd love to give it a shot.

Hey yogitab2798 ,
Sure if sanjana2000d is not working on it.

sanjana2000d,
How is this going ? Are you still interested in working on it?

Flags: needinfo?(sanjana2000d)

Hey Hubert, can you also share me the link of Mozilla channel?

Hey Hubert, there has been no response from sanjana2000d since 2 days and I have cloned and built Mozilla. Will you help me get started on this bug?

Hey yogitab2798,
Sure i'll assign to you. If you have setup firefox. See the second part of Comment 5 on how to fix.

Hi sanjana2000d,
I'm re-assigning it to yogitab2798, if you are interested we can find something else for you.

Assignee: sanjana2000d → yogitab2798

Alright, thanks! I will update you with a PR soon

Attachment #9200363 - Attachment is obsolete: true
Attachment #9199982 - Attachment description: Bug 1674307 - Add focusin and focusout checkboxes in Event Listener Breakpoints r=bomsy → Bug 1674307 - Add tests for focusin and focusout checkboxes in Event Listener Breakpoints r=bomsy
Attachment #9199982 - Attachment description: Bug 1674307 - Add tests for focusin and focusout checkboxes in Event Listener Breakpoints r=bomsy → Bug 1674307 - Add focusin and focusout checkboxes in Event Listener Breakpoints r=bomsy
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a2e24377ae3
Add focusin and focusout checkboxes in Event Listener Breakpoints r=bomsy

https://hg.mozilla.org/mozilla-central/rev/7a2e24377ae3

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.