1764248 - There is no composition events in the "Event Listener Breakpoints"

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

1. Open DevTools and go to Debugger tab, and see "Event Listener Breakpoints"

What happened?

There is no composition events such as compositionstart, compositionupdate nor compositionend.

What should have happened?

They should be listed (perhaps, in Keyboard?)

Comment 1

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting!
We should add this and this would likely go under Keyboard events.

For whoever picks this up
Should not be too difficult to do. See Bug 1674307 as an example

Comment 2

[Patrick Gregory]

Hi, first-time contributor here. I think I'd like to pick this up.

I noticed that in Bug 1674307 the fix included some integration tests, however I don't see tests for all the options in this menu. Should I add tests for this one?

Comment 3

[Patrick Gregory]

Attachment: Bug 1764248 - Add composition event debug breakpoints r=bomsy

Comment 4

[Hubert Boma Manilla (:bomsy)]

(In reply to Patrick Gregory from comment #2)

Hi, first-time contributor here. I think I'd like to pick this up.

Thanks for picking this up, Patrick.

I noticed that in Bug 1674307 the fix included some integration tests, however I don't see tests for all the options in this menu. Should I add tests for this one?

Yeah, we should add tests for this.

We should eventually add test for all the other options.

Comment 5

[Patrick Gregory]

Apologies. I think this might be out of my depth at the moment.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 7

[Luke Swiderski]

Attachment: Bug 1764248 - Add composition event-listener breakpoints r=bomsy

Add compositionstart, compositionupdate and compositionend
to keyboard event-listener-breakpoints.
Add mochitests for each.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6371eafaa8a2
Add composition event-listener breakpoints r=bomsy

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6371eafaa8a2

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on Firefox 104.0(build ID: 20220818191623) on Ubuntu 22.04, using the STR from the Description. Verified as fixed on Firefox 105.0b5(build ID: 20220830185924) and Nightly 106.0a1(build ID: 20220831215447) on Ubuntu 22.04, Windows 10, macOS 12.