1674357 - Remove lifetime from DevTools protocol

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

We support a notion of lifetime in the protocol, but it's only used once: https://searchfox.org/mozilla-central/source/devtools/shared/specs/styles.js#21

types.addLifetime("walker", "walker");

And I think in order to actually apply to anything, we would need a type to be defined as walker:something, as shown in the only test that exercizes the feature: https://searchfox.org/mozilla-central/rev/d866b96d74ec2a63f09ee418f048d23f4fd379a2/devtools/shared/protocol/tests/xpcshell/test_protocol_children.js#242

Furthermore, the coverage shows only two hits for the code that handles a detected lifetime in a type:
https://coverage.moz.tools/#revision=latest&path=devtools%2Fshared%2Fprotocol%2Ftypes.js&view=file&line=89

I believe those 2 hits are from the unit-test. (any other real devtools type would show up way more often, the embedding method has 70 000 hits).

We should remove this, it's confusing.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1674357 - [devtools] Remove lifetime from DevTools protocol

Depends on D95299

The lifetime feature seems unused in DevTools. Removing it should have no impact.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4023b0e2d44b
[devtools] Remove lifetime from DevTools protocol r=ochameau,devtools-backward-compat-reviewers

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4023b0e2d44b