Closed Bug 1674362 Opened 5 years ago Closed 5 years ago

Split styles.js actors/fronts/specs in individual file for StyleRule and PageStyle actors

Categories

(DevTools :: Style Editor, task, P3)

task

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We should stick to one actor/front/spec per file when possible.

Blocks: 1674357

The actors/styles.js file contained two actors.
This change moves each actor in its own file.
A shared actors/utils/style-utils file is also created to host shared helpers.

Depends on D95297

After moving actors to individual files, we should also do the same with specs.
Both actors are using shared types, which are moved to a shared types file.

Depends on D95298

Also extract the corresponding fronts in individual files.

Blocks: 1674371
Summary: Split styles actors/fronts/specs in individual file for StyleRule and PageStyle actors → Split styles.js actors/fronts/specs in individual file for StyleRule and PageStyle actors
Blocks: 1674405
Blocks: 1674812
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ac173a78f0d [devtools] Extract PageStyle and StyleRule actors to individual files r=rcaliman https://hg.mozilla.org/integration/autoland/rev/ebe29a69d0c9 [devtools] Extract PageStyle and StyleRule specs to individual files r=rcaliman,devtools-backward-compat-reviewers https://hg.mozilla.org/integration/autoland/rev/093216e70a33 [devtools] Extract PageStyle and StyleRule fronts to individual files r=rcaliman,devtools-backward-compat-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: