1674407 - tabs.create() should wait for window load

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[John Bieling]

A call to browser.tabs.create during Thunderbird start fails with an error about tabmail not being defined.

https://thunderbird.topicbox.com/groups/addons/T5e49f3ac49bed9a1-Mcfba2a4d42d7d2b36ce290d6/how-to-open-a-content-tab-at-startup

This works as expected in Firefox. The difference is, that the firefox implementation is waiting for browser-delayed-startup-finished.

We have something similar "mail-delayed-startup-finished" and we should use that.

Comment 1

[John Bieling]

Attachment: bug1674407.patch

Patch using the same method as firefox, but with the "mail-delayed-startup-finished" notification.

Comment 2

[Thomas D. (:thomas8)]

(In reply to John Bieling (:TbSync) from comment #0)

A call to browser.taps.create during Thunderbird start fails with an error about tabmail not being defined.

Well, a call to browser.taps.create will always fail becaused "tabs" is misspelled... ;-)

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9184808 [details] [diff] [review]
bug1674407.patch

Review of attachment 9184808 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 4

[Magnus Melin [:mkmelin]]

Do you have a try run?
Please set affected flags for 78 and beta.

Comment 5

[John Bieling]

I never know what the result of the try run is telling me:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=653fc68dd078afc61b4bcf0e9174a9e962969644&selectedTaskRun=ZtLiKjj_T-2MEzWG0OFZrw.0

Comment 6

[Magnus Melin [:mkmelin]]

Doesn't look like any new oranges, which is what to look out for.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/38bd4260fb50
tabs.create() should wait for window load. r=mkmelin

Comment 8

[John Bieling]

Comment on attachment 9184808 [details] [diff] [review]
bug1674407.patch

[Approval Request Comment]
User impact if declined: Cannot use browser.tabs.create() during Thunderbird start
Testing completed (on c-c, etc.): OK
Risk to taking this patch (and alternatives if risky): None

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9184808 [details] [diff] [review]
bug1674407.patch

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 83.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/149b60e55f75

Comment 11

[John Bieling]

Comment on attachment 9184808 [details] [diff] [review]
bug1674407.patch

[Approval Request Comment]
User impact if declined: Cannot use browser.tabs.create() during Thunderbird start
Testing completed (on c-c, etc.): OK
Risk to taking this patch (and alternatives if risky): Noneatch (and alternatives if risky):

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9184808 [details] [diff] [review]
bug1674407.patch

[Triage Comment]
Approved for esr78

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/43a3c6a9bf59

Comment 14

[Rob Lemley [:rjl]]

Causes test failures on esr78:
https://treeherder.mozilla.org/jobs?repo=comm-esr78&selectedTaskRun=VkCn9OXwSmiCTLVGxP74vw.0

Backing this bug out "fixed" the tests, but they should probably be made to work rather than backing out.

Comment 15

[John Bieling]

I will check the test.

Comment 16

[John Bieling]

I was able to build ESR and the result is not nice: The patch works on trunk but not on ESR. It is not just the test, it really does not work. I have to investigate.

It looks like this patch is still on comm-esr78 ? If so, it has to be removed before release of 78.5

Comment 17

[John Bieling]

Fail in ESR78 is due to bug 1660904 not being uplifted.

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 78.5.0 (backout):
https://hg.mozilla.org/releases/comm-esr78/rev/997190de89d3

Comment 19

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Attachment: 1674407-esr78-fixes.diff

This fixes the problems for this bug on 78. We're waiting for a notification that never arrives, because it doesn't exist on 78. Not really any risk, but I've asked Magnus for review anyway.

Comment 20

[Magnus Melin [:mkmelin]]

Comment on attachment 9187958 [details] [diff] [review]
1674407-esr78-fixes.diff

Review of attachment 9187958 [details] [diff] [review]:
-----------------------------------------------------------------

LGMT, r=mkmelin

Comment 21

[Rob Lemley [:rjl]]

Comment on attachment 9187958 [details] [diff] [review]
1674407-esr78-fixes.diff

[Triage Comment]
ESR78 fixes for previously approved changes.

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/24495b7b6e5c
https://hg.mozilla.org/releases/comm-esr78/rev/bff4ba33c8ee