1674421 - Port bug 1565574 to make opening the browser work again

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

Bug 1565574 introduced a new dialog to ask what app I want to open when I click on a link.
FX is preselected ("Allow this site to open the https link with Firefox Nightly?") and clicking "Open Link" doesn't open FX but I get the error:
can't access property "isSystemPrincipal", aPrincipal is null ContentDispatchChooser.jsm:71

handleURI Choo
AsyncFunctionThrow self-hosted:678
(Async: async)
openLinkExternally chrome://communicator/content/contentAreaClick.js:230
contentAreaClick chrome://communicator/content/contentAreaClick.js:200
onclick chrome://messenger/content/messenger.xhtml:1

Using "Choose a different application" and selecting FX and then ticking "Always use this application to open https links" opens FX. But clicking the same link again in TB shows the same dialog again with the same behaviour as before.

I played then with disabling security.external_protocol_requires_permission which let me open as before the the bug and re-enabling the pref I get now the dialog without the preselected FX and this error:
Uncaught TypeError: can't access property "focus", defaultButton is undefined dialog.js:301:15

focusInit chrome://global/content/elements/dialog.js:301
setTimeout handler*postLoadInit chrome://global/content/elements/dialog.js:314
MozDialog chrome://global/content/elements/dialog.js:61
MozDialog chrome://global/content/elements/dialog.js:61
CustomElementConstructor* chrome://global/content/elements/dialog.js:516
<anonymous> chrome://global/content/customElements.js:839
<anonymous> chrome://global/content/customElements.js:862
<anonymous> chrome://messenger/content/customElements.js:14
<anonymous> chrome://messenger/content/customElements.js:37
observe resource://gre/modules/MailGlue.jsm:234

Clicking on "Choose Application" in the dialog gives now the first error above directly.

Comment 1

[Richard Marti (:Paenglab)]

Magnus, what do you think, do you want to fix the issues or do you want to only set security.external_protocol_requires_permission to false?
If latter, I can make a patch.

Comment 2

[Paul Zühlcke [:pbz]]

clicking "Open Link" doesn't open FX but I get the error:
can't access property "isSystemPrincipal", aPrincipal is null ContentDispatchChooser.jsm:71

I'm fixing this in Bug 1674437.

Comment 3

[Magnus Melin [:mkmelin]]

Bug 1565574 seems to be a very complex issue, but if I understand it correctly it should not be a serious issue if an issue at all in the Thunderbird context. I'd think http/https should be excluded from those asks for an application like Thunderbird, if we'd need it for other protocols. Asking for permission to open http links every time is clearly not a alternative.

I think we should just set security.external_protocol_requires_permission to false.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1674421-not-show-protocol-prompt.patch

Disable the external application prompt.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9185020 [details] [diff] [review]
1674421-not-show-protocol-prompt.patch

Review of attachment 9185020 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/57d49d77f22b
Set the pref to not show a prompt to open external applications (like http links). r=mkmelin