1674485 - URL heuristic result icon is lost after selecting a one-off

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Harry Twyford]

Bug 1667766 changed the behaviour of URL heuristic results (e.g. autofill) to be restyled as search results when the user cycled through the one-offs. This was to better reflect what would happen if the user selected the heuristic result while that one-off was selected. However, when the one-offs are no longer selected, we lose the result's original icon and instead show the generic search glass icon. We should instead revert to the original icon, fully restoring the result to its original state.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1667766

Comment 2

[Harry Twyford]

Attachment: Bug 1674485 - Restore URL heuristic icon after unselecting a one-off. r?adw!

Comment 3

[Harry Twyford]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d4c49d6cd86af323ca968ee9307c3baebcbedac

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/680264f74a86
Restore URL heuristic icon after unselecting a one-off. r=adw

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on browser_oneOffs_heuristicRestyle.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=680264f74a86845ea1e2a86051a05083bb2a38f0&searchStr=bc&selectedTaskRun=NOHCkiAATqK2134oLilwhg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=320538864&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/39ea4bbe0f8010e8f4dc9df7746796029e9293ed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f1d788065fe
Restore URL heuristic icon after unselecting a one-off. r=adw

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2f1d788065fe

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Harry, makes sense that your patch caused the following improvement?
== Change summary for alert #27509 (as of Wed, 04 Nov 2020 12:24:15 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
56%	about_newtab_with_snippets		windows10-64-shippable-qr	e10s stylo webrender	67.83 -> 29.89

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27509

Comment 9

[Mike de Boer [:mikedeboer]]

Alexandru, I'm placing my bets on bug 1674279.

Comment 10

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Mike de Boer [:mikedeboer] from comment #9)

Alexandru, I'm placing my bets on bug 1674279.

How much? haha
Yeah, judging after the code, makes sense. Otherwise the graph si pretty inconclusive.

Comment 11

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Alexandru Ionescu (needinfo me) [:alexandrui] from comment #10)

(In reply to Mike de Boer [:mikedeboer] from comment #9)

Alexandru, I'm placing my bets on bug 1674279.

Yeah, judging after the code, makes sense. Otherwise the graph si pretty inconclusive.

The alert is linked to bug 1672517, should we reassign it to bug 1674279 as suggested in comment 9?

Comment 12

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Done