Open
Bug 1674511
Opened 4 years ago
Updated 4 months ago
Reduce the amount of work we do for location hash and history push/replaceState changes in XULBrowserWindow's onLocationChange
Categories
(Firefox :: General, task, P3)
Tracking
()
NEW
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | affected |
People
(Reporter: Gijs, Unassigned)
References
Details
(Keywords: perf:responsiveness)
The method at issue is https://searchfox.org/mozilla-central/rev/d866b96d74ec2a63f09ee418f048d23f4fd379a2/browser/base/content/browser.js#5363
See earlier changes in bug 1594472.
Same document loads cannot change the document principal (though they can change the URI!) so I believe that we do not need to run the identity block code, nor some of the other code in this method.
This is also a foot gun when we expect that these methods only get called when the page changes.
|
||
Comment 1•4 years ago
|
||
Yeah, that seems like a safe thing to do off-hand, though of course we will discover edge cases along the way :P
|
||
Comment 2•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Component: General → DOM: Navigation
Product: Firefox → Core
|
Reporter | |
Updated•4 years ago
|
Component: DOM: Navigation → General
Product: Core → Firefox
|
||
Comment 3•4 years ago
|
||
Gijs, could you estimate a priority & severity for this?
Flags: needinfo?(gijskruitbosch+bugs)
|
|
Reporter | |
Updated•4 years ago
|
Severity: -- → S3
Flags: needinfo?(gijskruitbosch+bugs)
Priority: -- → P3
Whiteboard: [fxperf:p3]
|
||
Updated•5 months ago
|
|
||
Updated•4 months ago
|
Type: defect → task
Performance Impact: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•