1673490 - Bookmarks toolbar appears then hides when bookmarking a PDF document (due to same-document location changes)

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Make sure PDF.js is enabled
Open https://www.irs.gov/pub/irs-pdf/f1040.pdf
Bookmarks Toolbar should be set to "Only on New Tab"
Click the bookmark star
Change the location of the bookmark to Bookmarks Toolbar
Hit Save

ER:
The bookmarks toolbar should be opened and remain open until the tab is changed or the page is navigated away

AR:
The toolbar appears then disappears immediately after

With some debugging I'm seeing that browsing around the pdf.js document generated somewhat random calls to onLocationChange (chrome://browser/content/tabbrowser.js#6246).

@Brendan, do you know why we're getting these events? Is it something we can limit or at least stop from propagating to browser UI?

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1673490 - do not update bookmarks toolbar visibility for same-document navigations, r?jaws

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86639f67d587
do not update bookmarks toolbar visibility for same-document navigations, r=jaws

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/86639f67d587

Comment 4

[Daniel Cicas [:dcicas], Release QA]

Hello,

Verified this issue on Fx 84.0b1 on Win 10, ubuntu and mac os.