Closed Bug 1673490 Opened 1 year ago Closed 1 year ago

Bookmarks toolbar appears then hides when bookmarking a PDF document (due to same-document location changes)

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Desktop
Windows
defect

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox84 --- verified

People

(Reporter: jaws, Assigned: Gijs)

References

Details

Attachments

(1 file)

STR:
Make sure PDF.js is enabled
Open https://www.irs.gov/pub/irs-pdf/f1040.pdf
Bookmarks Toolbar should be set to "Only on New Tab"
Click the bookmark star
Change the location of the bookmark to Bookmarks Toolbar
Hit Save

ER:
The bookmarks toolbar should be opened and remain open until the tab is changed or the page is navigated away

AR:
The toolbar appears then disappears immediately after

With some debugging I'm seeing that browsing around the pdf.js document generated somewhat random calls to onLocationChange (chrome://browser/content/tabbrowser.js#6246).

@Brendan, do you know why we're getting these events? Is it something we can limit or at least stop from propagating to browser UI?

Flags: needinfo?(bdahl)
Component: New Tab Page → Toolbars and Customization
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(bdahl)
OS: Unspecified → Windows
Priority: P3 → P1
Hardware: Unspecified → Desktop
Summary: Bookmarks toolbar appears then hides when bookmarking a PDF document → Bookmarks toolbar appears then hides when bookmarking a PDF document (due to same-document location changes)
See Also: → 1674511
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/86639f67d587
do not update bookmarks toolbar visibility for same-document navigations, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Hello,

Verified this issue on Fx 84.0b1 on Win 10, ubuntu and mac os.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.