1674606 - activity manager theming

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Wayne Mery (:wsmwk)]

Version 78 lacks dark mode. I assume light mode as well

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1674606-activity-themeable.patch

This should do the theming.

I haven't updated the icons. This should be done in a follow-up bug.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1674606-activity-themeable.patch

Found an error in mac file.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9185030 [details] [diff] [review]
1674606-activity-themeable.patch

Review of attachment 9185030 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for updating this, looks good.
Just a little nit.

::: mail/themes/osx/mail/activity/activity.css
@@ +114,5 @@
>  }
>  
>  richlistitem[is="activity-group-richlistitem"] button {
>    list-style-image: url(chrome://messenger/skin/activity/buttons.png);
>  }

Can we remove this like you did in the Linux file?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1674606-activity-themeable.patch

(In reply to Alessandro Castellani (:aleca) from comment #3)

Comment on attachment 9185030 [details] [diff] [review]
1674606-activity-themeable.patch

Review of attachment 9185030 [details] [diff] [review]:

::: mail/themes/osx/mail/activity/activity.css
@@ +114,5 @@

}

richlistitem[is="activity-group-richlistitem"] button {
list-style-image: url(chrome://messenger/skin/activity/buttons.png);
}

Can we remove this like you did in the Linux file?

Ahh, missed this. Removed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/806dcbb94296
Make the activity manager themeable. r=aleca

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9185230 [details] [diff] [review]
1674606-activity-themeable.patch

[Approval Request Comment]
User impact if declined: light activity manager when other UI is dark
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1674606-activity-themeable-ESR.patch

[Approval Request Comment]
User impact if declined: light activity manager when other UI is dark
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9185230 [details] [diff] [review]
1674606-activity-themeable.patch

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 83.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a0e4d40b0f60

Comment 10

[WaltS48 [:walts48]]

Did the Firefox developers drop the ball and forget to theme preferences, AOM, bookmark manager and other dialogs? Still light when using the Dark theme there.

Activity Manager looks themed in my test of 83.0b3 on Windows 10, and I can actually switch from the Dark back to the Default theme without having to restart.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9185396 [details] [diff] [review]
1674606-activity-themeable-ESR.patch

[Triage Comment]
Approved for esr78

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/7f049e8ef137

Comment 13

[WaltS48 [:walts48]]

Activity Manager themed in my test of the 78.5.0 release candidate on Windows 10 (20H2).