1674645 - Blogs & News Feeds - <Account name> title with angle brackets falsely suggests email address, and account name not updated in title timely

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Liscare]

Attachment: screenshot_accountSettings_blogsNewFeeds.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1. Go to Account Settings (see screenshot)
2. Open Account Actions
3. Choose Add Feed Account
4. Select the new feed account
5. Change the Account Name
6. Select an other component in the tab

Actual results:

• The account name in tree menu (on the left) is changed
• The account name in the tab is not changed
• The account title is Account Settings - <Blogs & New Feeds>

Expected results:

• The account name in the tab is changed
• The account title is Account Settings - Blogs & New Feeds

In the tab title, the name (Blogs & News Feeds by default) in angle braces is not an email address, it should haven't angle braces (see am-newsblog.js) and should be changed immediately after losting the focus on Account Name (see onBlur event).

Comment 1

[Liscare]

Similar to Bug 1666882

Comment 2

[Magnus Melin [:mkmelin]]

Do you want to take on fixing this too?

Comment 3

[Liscare]

Yes, when the patch for Bug 1666882 is accepted, I will take on fixing it too.

Comment 4

[Liscare]

Attachment: Bug 1674645 - Remove angle brackets from <Account name> title for newsblog in account settings which misrepresent it as the email address. r=thomasD

Comment 5

[Liscare]

Attachment: Bug 1674645 - Update account title onblur after change of newsblog account name in Account Settings. r=thomasD

Comment 6

[Thomas D. (:thomas8)]

Magnus, Lilian and I are done here, so if you're ok with the patches as reviewed by me, kindly set checkin-needed.
Next time, we'll fold the one-liner into the bigger patch, but for this time under the circumstances, it wasn't feasible.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bc1d766526bb
Remove angle brackets from <Account name> title for newsblog in account settings which misrepresent it as the email address. r=thomasD,mkmelin
https://hg.mozilla.org/comm-central/rev/12760c0fa074
Update account title onblur after change of newsblog account name in Account Settings. r=thomasD,mkmelin

Comment 8

[Magnus Melin [:mkmelin]]

Landed a followup for linting - https://hg.mozilla.org/comm-central/rev/a0847685cc04
Please always run ./mach eslint --fix comm/<path-to-files> to detect linting problems. This dir requires documenting return types as well.