Closed Bug 1674667 Opened 5 years ago Closed 5 years ago

SeaMonkey source tarball excludes too much

Categories

(SeaMonkey :: Release Engineering, defect)

defect

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey2.53
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.5)

Attachments

(1 file)

As mentioned in Bug 1618852 there are items starting .git that should not be excluded so exclusion list should be something like:
.git
.gitattributes
.gitkeep
.gitmodules

This backports bug 1621564

Attached patch Be more preciseSplinter Review

[Approval Request Comment]
Regression caused by (bug #): 1618852
User impact if declined: too much excluded in tarball
Testing completed (on m-c, etc.): 2.53.5
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

It would be good to have this in for 2.53.5 final

Attachment #9185056 - Flags: review?(frgrahl)
Attachment #9185056 - Flags: approval-comm-release?

Comment on attachment 9185056 [details] [diff] [review]
Be more precise

LGTM. Not for 2.57?

Attachment #9185056 - Flags: review?(frgrahl)
Attachment #9185056 - Flags: review+
Attachment #9185056 - Flags: approval-comm-release?
Attachment #9185056 - Flags: approval-comm-release+

Comment on attachment 9185056 [details] [diff] [review]
Be more precise

Oops, also needed for 2.57

Attachment #9185056 - Flags: approval-comm-esr60?
Attachment #9185056 - Flags: approval-comm-esr60? → approval-comm-esr60+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: