1674737 - Pass SpliceableJSONWriter to StreamJSONMarkerData, and attach UniqueJSONStrings

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Currently StreamJSONMarkerData functions (in marker definition structs) are given a JSONWriter reference.

Some markers, like GC major/minor/slice, need to splice JSON strings (without escaping them). So instead of a JSONWriter, we now give SpliceableJSONWriter to StreamJSONMarkerData.

Some other markers, like Screenshot, also need to store some data as unique strings.
To help with that, the UniqueJSONStrings object that's used when streaming a profile, will be attached to the SpliceableJSONWriter, and relevant functions will be added.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1674737 - Use SpliceableJSONWriter instead of JSONWriter when streaming markers - r?gregtatum

Some markers (e.g., GC major/minor/slice) need to splice JSON strings in their data.
So now, instead of JSONWriter, StreamJSONMarkerData functions will be given a mozilla::baseprofiler::SpliceableJSONWriter.

Depends on D95116

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1674737 - Make SpliceableJSONWriter optionally point at a UniqueJSONStrings, with pass-through functions - r?gregtatum

Some markers (e.g., Screenshot) use unique strings in their data.

The UniqueJSONStrings used during streaming is attached to the SpliceableJSONWriter, and StreamJSONMarkerData can use pass-through functions UniqueStringProperty() and UniqueStringElement().

Depends on D95511

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1674737 - Use SpliceableJSONWriter::UniqueStringElement in DeserializeAfterKindAndStream - r?gregtatum

Unique strings are used to encode all markers' 'name' field, SpliceableJSONWriter::UniqueStringElement can be used for that (instead of a caller-provided callback, which was necessary before UniqueJSONStrings was de-duplicated).

Depends on D95512

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c19cd174982c
Use SpliceableJSONWriter instead of JSONWriter when streaming markers - r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/d203ffa2b29e
Make SpliceableJSONWriter optionally point at a UniqueJSONStrings, with pass-through functions - r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/855f21902872
Use SpliceableJSONWriter::UniqueStringElement in DeserializeAfterKindAndStream - r=gregtatum

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c19cd174982c
https://hg.mozilla.org/mozilla-central/rev/d203ffa2b29e
https://hg.mozilla.org/mozilla-central/rev/855f21902872