Closed Bug 1674772 Opened 4 years ago Closed 4 years ago

Please indicate unit of Margin.

Categories

(Toolkit :: Printing, defect, P2)

Product:
Toolkit
Component:
Printing
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox82 --- unaffected
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- verified
firefox86 --- verified

People

(Reporter: alice0775, Assigned: sfoster)

References

Details

(Keywords: intl, nightly-community, Whiteboard: [print2020_v85])

Attachments

(2 files, 4 obsolete files)

screenshot
78.79 KB, image/png
Details
Bug 1674772 - New string for the 'Custom (inches) option and hidden described-by labels for each margin edge. r?mstriemer!
47 bytes, text/x-phabricator-request
Details | Review
Attached image screenshot —

Steps to reproduce:

  1. Ctrl+P > more settings > choose Custom of Margins dropdown

Actual results:
unit does not display.
It seems inch.

Expected results:
unit shou be shown.
And it should be in "mm" in Windows region is Japan

Summary: Pleas indicate unit of Margin. → Please indicate unit of Margin.
Has STR: --- → yes
Depends on: 1492776
Keywords: nightly-community, regression

:alice0775, could you try to find a regression range in using for example mozregression?

Keywords: regressionwindow-wanted
Blocks: 133787, 1664570
Keywords: regressionwindow-wanted → intl

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #1)

:alice0775, could you try to find a regression range in using for example mozregression?

This is new tab modal print preview implementation bug.

This seems like the kind of thing we want to fix in 85, so tagging it for that.

Severity: -- → S4
Keywords: regression
Priority: -- → P2
Whiteboard: [print2020_v85]
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Assignee: aethanyc → nobody
Status: ASSIGNED → NEW
Assignee: nobody → sfoster
Status: NEW → ASSIGNED

The margin units are in inches, and (currently at least) this is not user-selectable or variable by locale. My initial WIP patch tries to add the ".in" to the right of the unit input[type=number] value, but this gets quite awkward with RTL. We need the value and its unit to not get reversed but the number spinner controls should get reversed as normal in RTL.
I wonder if a better approach would be to put the unit in the margin type picker, ie. "Custom (inches)", which kinda acts as the label for this group.
A 3rd option would be to add it to the margin location lable, i.e. Top (inches), Bottom (inches) etc. But that seems like it will be repetitive and odd-looking.

Independent of how we label the unit, I wonder if we shouldn't make this millimeters (and convert behind the scenes when we update the printer setting) in an effort to be a bit more international-friendly. I can imagine most of the world trying to figure out how big 1/10 of an inch is, but even in N. America I think a mm is reasonably well understood, and a better pick for this size range anyhow?

I'll move forward with changing the "Custom" option value to read "Custom (inches)".
I wonder if the group of inputs for the top/bottom/left/right margin values should have a label using this string. In effect, this "Custom" option is the label, but I'm not sure if aria-labelled-by can point to an <option>?
Alternatively, I could have an offscreen label, but we've not done that yet in this UI so I'm hesitant to start now.

(In reply to Sam Foster [:sfoster] (he/him) from comment #14)

I'll move forward with changing the "Custom" option value to read "Custom (inches)".
I wonder if the group of inputs for the top/bottom/left/right margin values should have a label using this string. In effect, this "Custom" option is the label, but I'm not sure if aria-labelled-by can point to an <option>?
Alternatively, I could have an offscreen label, but we've not done that yet in this UI so I'm hesitant to start now.

Hi Sam, just saw your ping in the matrix:

  • IMO the "Custom (inches)" name for select option is reasonable
  • Currently each input for margins has the label such as "Top", "Bottom", ... we could enhance this by providing them all with aria-describedby that refers to a hidden label with the accessible name inches (not offscreen, since we don't want it in the a11y tree).
  • Also, looks like the select does not have a label, which it should. Currently "Margins" label is set to be for the #margins-select container, which has no effect (you can see this flagged as an issue if you try the accessibility panel in browser toolbox).
Attachment #9191447 - Attachment description: Bug 1674772 - WIP: Add the 'in.' unit indicator to the custom margin fields. → Bug 1674772 - New string for the 'Custom (inches) option and hidden described-by labels for each margin edge. r?mstriemer!
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6cda2e086671
New string for the 'Custom (inches) option and hidden described-by labels for each margin edge. r=mstriemer,fluent-reviewers

https://hg.mozilla.org/mozilla-central/rev/6cda2e086671

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
See Also: → 1682334
Flags: qe-verify+

Hello,

Confirming this a verified fixed on 86.0a1(20201218095607) and 85.0b3(20201217185930) with macOS 10.14.6, Win10x64 and Ubuntu 20.04

Status: RESOLVED → VERIFIED
status-firefox85: fixed → verified
status-firefox86: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: