1674806 - Remove windowtype attribute from browser/components/preferences/dialogs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P5)

Description

[Tim Nguyen :ntim]

windowtype is apparently a convention for the window enumerator, which I don't think is very useful in this context.

Let's try to remove this attribute: https://searchfox.org/mozilla-central/search?q=windowtype%3D%22&path=preferences%2Fdialogs&case=true&regexp=false

Comment 1

[Jacob]

Can I take this bug?

Comment 2

[Tim Nguyen :ntim]

(In reply to Jacob from comment #1)

Can I take this bug?

Yeah, feel free to submit a patch and the bug will be automatically assigned accordingly.

Depending on what you need, there are resources to get started here: https://firefox-source-docs.mozilla.org/setup/index.html .

If not, please let me know using the "Request information from" field if you have any questions :)

Comment 3

[gero]

Hi all,

if Jacob does not patch, i can gladly start my contribution with this issue. Tim, could I or should wait further?

Comment 4

[Tim Nguyen :ntim]

(In reply to gero from comment #3)

Hi all,

if Jacob does not patch, i can gladly start my contribution with this issue. Tim, could I or should wait further?

Feel free to submit a patch if you have one, nobody has submitted a patch yet.

Comment 5

[gero]

Attachment: Bug 1674806 - Remove windowtype attribute where it is obsolete r=ntim

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0372a3bf120a
Remove windowtype attribute where it is obsolete r=ntim,preferences-reviewers

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0372a3bf120a