1674827 - Re-enable startup_about_home_paint_cached Talos test

Status: RESOLVED FIXED

(Testing :: Talos, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

After some analysis, it seems that this test is failing because:

1. During the getInfo.html page load step that runs during the profile-setup part of Talos, when the browser shuts down, we use AsyncShutdown to write a cache of the current about:home state to disk. However, because the getInfo.html step happens so quickly, sometimes at this point, that cache write doesn't include any data for TopSites (since the TopSitesFeed hasn't finished initializing yet).
2. During the test then, the about:home document loads, but because the TopSites section hadn't initialized, no TopSites appear, which means that the topsites_first_painted_ts timestamp never gets set, meaning that the Telemetry Scalar that the startup_about_home_paint_cached test waits for also doesn't get set.

Comment 1

[Greg Mierzwinski [:sparky]]

Hi :mconley, is this still a priority for you and if so, is there anything we can do to help?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1674827 - Make sure getInfo.html waits for about:newtab's TopSitesFeed to finish initting when setting up a Talos test. r?sparky!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Yeah, thanks sparky - it turns out I've had a WIP patch for this lying around that I never posted because I must have gotten distracted by other things.

Here's a try push: https://treeherder.mozilla.org/jobs?repo=try&revision=01fe4757bc138e5afd4d68b92a0c826b850cf642

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Updated try push: https://treeherder.mozilla.org/jobs?repo=try&revision=c640e0cf1ec373593016d3b0e2b3519c8b474be2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94ca7b907b60
Make sure getInfo.html waits for about:newtab's TopSitesFeed to finish initting when setting up a Talos test. r=perftest-reviewers,sparky

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/94ca7b907b60