1674895 - Intermittent comm/mail/test/browser/message-header/browser_phishingBar.js | rejection: can't access property "getElementsByTagName", msgFrame.contentDocument is null - stack: getBodyElement@chrome://openpgp/content/ui/enigmailMessengerOverlay.js:1372:5

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin+mozilla [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=320505288&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Io57YuecR_mBwGdNV9jpEQ/runs/0/artifacts/public/logs/live_backing.log

---

Maybe from bug 1672851```

Comment 1

[Alessandro Castellani [:aleca]]

I can't seem to be able to reproduce this locally, but I'll keep investigating as I might have been the culprit of this test failure.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1674895_phishbar.patch

Doesn't fix the problem, but with this applied running --verify works. And then the problem does show for me locally. (./mach test --headless --verify comm/mail/test/browser/message-header/browser_phishingBar.js)

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9185281 [details] [diff] [review]
bug1674895_phishbar.patch

Review of attachment 9185281 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, this makes the test fail consistently

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: bug1674895_phishbar.patch

Fixing the issue on top of your initial patch.

I'm not sure why but it seems that the messageParse() method runs 3 times during the testing of the scam notification.
I wonder if that's a sign of a deeper issue and we're running some opengpg methods when we shouldn't.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9185879 [details] [diff] [review]
bug1674895_phishbar.patch

Review of attachment 9185879 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/extensions/openpgp/content/ui/enigmailMessengerOverlay.js
@@ +1370,5 @@
>      // Thunderbird
>      let msgFrame = document.getElementById("messagepane");
> +    if (!msgFrame || !msgFrame.contentDocument) {
> +      return bodyElement;
> +    }

I'll adjust it slightly to just drop the body element declaration

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/869f3bb00de0
make browser_phishingBar.js pass when with --verify. r=aleca

Comment 7

[Intermittent Failures Robot]

3 failures in 4128 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform breakdown:

• windows7-32: 1
• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1674895&startday=2020-11-02&endday=2020-11-08&tree=all

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9185879 [details] [diff] [review]
bug1674895_phishbar.patch

[Triage Comment]
Test-related changes; the UI code changes are minimal and improve error detection for the test.

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/0a9abf72f9a2

Comment 10

[Rob Lemley [:rjl]]

Attachment: 1674895_esr78_followup.patch

Test passes locally on esr78 with this change.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/9661972336f8