Minor cleanup
Categories
(Core :: IPC: MSCOM, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(5 files, 1 obsolete file)
Just some minor cleanup changes I'd like to make
|
Assignee | |
Comment 1•4 years ago
|
||
HRESULT is typedef'd as long, so this patch harmonizes the return codes.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Just a quick patch to reference an existing zeroed-out GUID instead of
instantiating a new one.
Depends on D95597
|
|
Assignee | |
Comment 3•4 years ago
|
||
This is a new check that I'd like to use in some future patches.
Depends on D95598
|
|
Assignee | |
Comment 4•4 years ago
|
||
Some cleanup in our smart pointer stuff: Using move semantics lets us avoid
needing to hack around our static analysis.
Depends on D95599
|
|
Assignee | |
Comment 5•4 years ago
|
||
Just some additional annotations
Depends on D95600
|
|
Assignee | |
Comment 6•4 years ago
|
||
I just wanted to add a better explanation for what the magic 2 constant
is for.
Depends on D95601
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1f72c3f70a0 Part 1 - s/uint32_t/long/ for return codes in mscom/Utils.h; r=Jamie https://hg.mozilla.org/integration/autoland/rev/e88b258d7013 Part 2 - Use CLSID_NULL instead of a distinct null CLSID; r=Jamie https://hg.mozilla.org/integration/autoland/rev/071d1d593deb Part 3 - Add IsCurrentThreadNonMainMTA to mscom/Utils.h; r=Jamie https://hg.mozilla.org/integration/autoland/rev/a71e810d79d0 Part 4 - mscom/Ptr.h cleanup; r=Jamie https://hg.mozilla.org/integration/autoland/rev/9f6e1866a7c3 Part 5 - Some mscom::ApartmentRegion cleanup; r=Jamie https://hg.mozilla.org/integration/autoland/rev/e4f63ba14348 Part 6 - mscom::ActivationContext cleanup; r=Jamie
|
||
Comment 8•4 years ago
|
||
Backout for build bustage
Backout: https://hg.mozilla.org/integration/autoland/rev/4a9b0415e1d70ae4c5c738fb0aca6bb29bd77d32
Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=e4f63ba1434894e71cefeb49de23af0624ab8380
Failure log: https://treeherder.mozilla.org/logviewer?job_id=320597140&repo=autoland&lineNumber=9739
|
|
Assignee | |
Comment 9•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf06ee25890e2632c4d7e8c23dae3fbd5e86b5da
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf2fd0667ecc Part 1 - s/uint32_t/long/ for return codes in mscom/Utils.h; r=Jamie https://hg.mozilla.org/integration/autoland/rev/35bbc3ee7862 Part 2 - Use CLSID_NULL instead of a distinct null CLSID; r=Jamie https://hg.mozilla.org/integration/autoland/rev/0b263b19e04e Part 3 - Add IsCurrentThreadNonMainMTA to mscom/Utils.h; r=Jamie https://hg.mozilla.org/integration/autoland/rev/d4a1afbdb13b Part 4 - Some mscom::ApartmentRegion cleanup; r=Jamie https://hg.mozilla.org/integration/autoland/rev/07521b8731a9 Part 5 - mscom::ActivationContext cleanup; r=Jamie
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bf2fd0667ecc
https://hg.mozilla.org/mozilla-central/rev/35bbc3ee7862
https://hg.mozilla.org/mozilla-central/rev/0b263b19e04e
https://hg.mozilla.org/mozilla-central/rev/d4a1afbdb13b
https://hg.mozilla.org/mozilla-central/rev/07521b8731a9
Description
•