1674902 - Minor cleanup

Status: RESOLVED FIXED

(Core :: IPC: MSCOM, task)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Just some minor cleanup changes I'd like to make

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674902: Part 1 - s/uint32_t/long/ for return codes in mscom/Utils.h; r=Jamie

HRESULT is typedef'd as long, so this patch harmonizes the return codes.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674902: Part 2 - Use CLSID_NULL instead of a distinct null CLSID; r=Jamie

Just a quick patch to reference an existing zeroed-out GUID instead of
instantiating a new one.

Depends on D95597

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674902: Part 3 - Add IsCurrentThreadNonMainMTA to mscom/Utils.h; r=Jamie

This is a new check that I'd like to use in some future patches.

Depends on D95598

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674902: Part 4 - mscom/Ptr.h cleanup; r=Jamie

Some cleanup in our smart pointer stuff: Using move semantics lets us avoid
needing to hack around our static analysis.

Depends on D95599

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674902: Part 4 - Some mscom::ApartmentRegion cleanup; r=Jamie

Just some additional annotations

Depends on D95600

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674902: Part 5 - mscom::ActivationContext cleanup; r=Jamie

I just wanted to add a better explanation for what the magic 2 constant
is for.

Depends on D95601

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1f72c3f70a0
Part 1 - s/uint32_t/long/ for return codes in mscom/Utils.h; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/e88b258d7013
Part 2 - Use CLSID_NULL instead of a distinct null CLSID; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/071d1d593deb
Part 3 - Add IsCurrentThreadNonMainMTA to mscom/Utils.h; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/a71e810d79d0
Part 4 - mscom/Ptr.h cleanup; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/9f6e1866a7c3
Part 5 - Some mscom::ApartmentRegion cleanup; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/e4f63ba14348
Part 6 - mscom::ActivationContext cleanup; r=Jamie

Comment 8

[Cristina Coroiu [:ccoroiu]]

Backout for build bustage

Backout: https://hg.mozilla.org/integration/autoland/rev/4a9b0415e1d70ae4c5c738fb0aca6bb29bd77d32

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=e4f63ba1434894e71cefeb49de23af0624ab8380

Failure log: https://treeherder.mozilla.org/logviewer?job_id=320597140&repo=autoland&lineNumber=9739

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf06ee25890e2632c4d7e8c23dae3fbd5e86b5da

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf2fd0667ecc
Part 1 - s/uint32_t/long/ for return codes in mscom/Utils.h; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/35bbc3ee7862
Part 2 - Use CLSID_NULL instead of a distinct null CLSID; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/0b263b19e04e
Part 3 - Add IsCurrentThreadNonMainMTA to mscom/Utils.h; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/d4a1afbdb13b
Part 4 - Some mscom::ApartmentRegion cleanup; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/07521b8731a9
Part 5 - mscom::ActivationContext cleanup; r=Jamie

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bf2fd0667ecc
https://hg.mozilla.org/mozilla-central/rev/35bbc3ee7862
https://hg.mozilla.org/mozilla-central/rev/0b263b19e04e
https://hg.mozilla.org/mozilla-central/rev/d4a1afbdb13b
https://hg.mozilla.org/mozilla-central/rev/07521b8731a9