1674904 - Refactor component registration code

Status: RESOLVED FIXED

(Core :: IPC: MSCOM, task)

Description

[(No longer employed by Mozilla) Aaron Klotz]

I want to replace the registration code that we use in Handler with a more generic implementation in Module and also supports DLL surrogates.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674904: Part 1 - Change mscom registration to dynamically link to GetProxyDllInfo when built outside of xul; r=Jamie

We need this so that the registration code is more versatile and may be linked
from outside of xul.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674904: Part 2 - New dll registration code in mscom/oop/module; r=Jamie

We add new DLL registration code. This is a rather generic function that
permits the following:

• Registering multiple CLSIDs for the same DLL;
• Registering an optional AppID. Registering an AppID allows us to use a
  DllSurrogate to host the DLL out-of-process using Windows' built-in
  dllhost.exe. I'll be using this feature in a future bug.
• Supporting all available threading modelsl;
• Capable of registering either inproc servers or inproc handlers;
• Using the transaction-based registry API so that we can cleanly rollback
  during registration if any part(s) of it fail.

Depends on D95605

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674904: Part 3 - Replace dll reg code in mscom/oop/Handler with calls to mscom/oop/Module; r=Jamie

Handler should now delegate its registration to Module.

Depends on D95606

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674904: Part 4 - Update AccessibleHandler to delayload dependencies that are only used during registration; r=Jamie

We should delayload DLLs that for APIs that are only used during registration
so that they aren't referenced during normal operation.

Depends on D95608

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7322c3af8006
Part 1 - Change mscom registration to dynamically link to GetProxyDllInfo when built outside of xul; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/660cdea23685
Part 2 - New dll registration code in mscom/oop/module; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/b3b7d68c33f6
Part 3 - Replace dll reg code in mscom/oop/Handler with calls to mscom/oop/Module; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/50576e0fbd98
Part 4 - Update AccessibleHandler to delayload dependencies that are only used during registration; r=Jamie

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1674904: Part 5 - Add GetProxyDllInfo to AccessibleHandler.dll's EXPORTS; r=Jamie

Now that non-XUL builds of Registration.cpp use GetProcAddress to resolve
GetProxyDllInfo (from part 1), we need to ensure that we export the handler's
implementation.

Comment 7

[Dorel Luca [:dluca]]

Backed out 4 changesets (bug 1674904) for Build bustage in worker/checkouts/gecko/config/rules.mk. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=320754921&repo=autoland&lineNumber=8470

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=YFu36-cgTIiPIcH3KyRtJQ.0&revision=50576e0fbd98256d86f411faa702a99d2ee1ea84

Backout:
https://hg.mozilla.org/integration/autoland/rev/260e4a7da897063f2c5c7541fe7d8dbc905b3a2b

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffbdcb624a139ac17ff11f196711e7fd4344ba03

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc27f9c33843
Part 1 - Change mscom registration to dynamically link to GetProxyDllInfo when built outside of xul; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/1ee6692a8dd0
Part 2 - New dll registration code in mscom/oop/module; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/0a275914d8a8
Part 3 - Replace dll reg code in mscom/oop/Handler with calls to mscom/oop/Module; r=Jamie
https://hg.mozilla.org/integration/autoland/rev/1b99873f3735
Part 4 - Update AccessibleHandler to delayload dependencies that are only used during registration; r=Jamie

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bc27f9c33843
https://hg.mozilla.org/mozilla-central/rev/1ee6692a8dd0
https://hg.mozilla.org/mozilla-central/rev/0a275914d8a8
https://hg.mozilla.org/mozilla-central/rev/1b99873f3735