1675056 - Error reported upon drag and drop of event in calendar views

Status: NEW

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Thunderbird 84.0a1 (2020-11-03)

History: Create an event. Switch to month view and drag and drop the event to another day.

Error: Drop shadow is shown but event is not moved after releasing the mouse.

Console shows:
TypeError: can't access property "isNegative", aDuration is null Ical.jsm:5397:19
icaltime_add resource:///modules/calendar/Ical.jsm:5397
addDuration resource:///components/calDateTime.js:137
unwrapSetter resource:///modules/calendar/Ical.jsm:25
unwrap resource:///modules/calendar/Ical.jsm:21
addDropShadows chrome://calendar/content/widgets/calendar-dnd-widgets.js:77
setAttribute chrome://calendar/content/widgets/calendar-dnd-widgets.js:127
onDragEnter chrome://calendar/content/widgets/calendar-dnd-widgets.js:202
invokeEventDragSession chrome://calendar/content/calendar-dnd-listener.js:656
MozCalendarEditableItem chrome://calendar/content/calendar-editable-item.js:123
(Async: EventListener.handleEvent)
MozCalendarEditableItem chrome://calendar/content/calendar-editable-item.js:106
MozCalendarMonthDayBoxItem chrome://calendar/content/calendar-month-view.js:267
addItem chrome://calendar/content/calendar-month-view.js:166
doAddItem chrome://calendar/content/calendar-month-base-view.js:692
forEach self-hosted:206
doAddItem chrome://calendar/content/calendar-month-base-view.js:692
onGetResult chrome://calendar/content/calendar-base-view.js:232
onGetResult resource:///modules/CalCompositeCalendar.jsm:525
queueItems resource:///modules/CalStorageCalendar.jsm:692
getItems resource:///modules/CalStorageCalendar.jsm:870
AsyncFunctionNext self-hosted:674
(Async: async)
getItems resource:///modules/CalCompositeCalendar.jsm:393
execute chrome://calendar/content/calendar-base-view.js:285
addItemsFromCalendar chrome://calendar/content/calendar-base-view.js:805
refresh chrome://calendar/content/calendar-base-view.js:784
setDateRange chrome://calendar/content/calendar-month-base-view.js:297
showDate chrome://calendar/content/calendar-month-base-view.js:244
goToDay chrome://calendar/content/calendar-views.js:227
switchToView chrome://calendar/content/calendar-views-utils.js:290
switchCalendarView chrome://calendar/content/calendar-tabs.js:397
doCommand chrome://calendar/content/calendar-command-controller.js:443
goDoCommand chrome://global/content/globalOverlay.js:101
oncommand chrome://messenger/content/messenger.xhtml:1

Could be some problem with initialization or selection or something else because it seems to work after a few tries. Or it fails the first time the view is displayed after startup.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

This happens when mShadowOffset hasn't been set https://searchfox.org/comm-central/rev/1e0c7b80dc66bfaa61a8f4ca87b0e5b15e869fb7/calendar/base/content/widgets/calendar-dnd-widgets.js#198

This can also happen if dragging in the week/day view allday header. Or dragging from the week/day view column to the allday header.