1683328 - Creating event by dragging in calendar view: text edit of description is hanging - happens in cases where auto-scroll to create new fails

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[MozBug20]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

Create an event by dragging in calender view (without need to scroll view). Then edit description text.

Actual results:

It is not possible to terminate editing of description text. Text cursor continues to blink. You cannot deselect the newly created event, by clicking elsewhere. You cannot select a different event by clicking on it. You cannot switch to view another week, etc.
In fact Calendar is hanging.
I did not find a way to solve this, except quitting Thunderbird and starting again.

Expected results:

Text editing should be terminated by clicking elsewhere, as in previous versions.

Comment 1

[Magnus Melin [:mkmelin]]

Seems to work find for me. Clicking elsewhere, or Enter, will finish the new event.

Comment 2

[MozBug20]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Seems to work find for me. Clicking elsewhere, or Enter, will finish the new event.

I tried to reproduce the bug and indeed bug description above is incomplete.

The above effect occurs after you had tried to create an event by dragging where end time is out of view and therefore auto-scroll should occur (see bug 1683326).
Also by accident now i found, that text editing may be terminated by pressing TAB (instead of ENTER in earlier versions), however one still cannot select an existing event by clicking on it and you cannot switch to view another week.

Comment 3

[Olav Seyfarth]

My colleague (Windows) and I (Linux) see a possibly related issue (shall I open separately? in this component?):

Be e.g. in week view. Drag a new entry. Old behavior was that I can edit its title, then enter to save it. New behavior (since December?) is that the new entry is auto-closed immdeately – and saved without title. I may then double-click and edit it, but the old way was way better IMHO.

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Even with auto-scroll fixed (bug 1683326), you can still get an error if you move beyond the scroll area and move into the allday header.

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1683328 - Stop ending a column mouse drag when resizing or creating events. r=darktrojan

We only end the drag if we are moving an event.

Depends on D130342

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

Note that the patch will fix this bug (dragging to create an event), but the same error can occur if you drag to move the event into the allday header, but I'll leave that to bug 1675056.

Comment 7

[Henry Wilkes (they/them) [:henry-x]]

Please land the patch after D130342 in bug 1683326

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc92ad2ce71c
Stop ending a column mouse drag when resizing or creating events. r=darktrojan

Comment 9

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9249208 [details]
Bug 1683328 - Stop ending a column mouse drag when resizing or creating events. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Dragging to create or extend an event can end earlier than necessary if the user accidentally leave the view. Moreover, it is converted into a drag session, which can cause errors on dropping.
Testing completed (on c-c, etc.): No tests.
Risk to taking this patch (and alternatives if risky): Low risk.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9249208 [details]
Bug 1683328 - Stop ending a column mouse drag when resizing or creating events. r=darktrojan

[Triage Comment]
Approved for beta

bug 1683326 uplift first

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 95.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/32ff7c300b53

Comment 12

[Henry Wilkes (they/them) [:henry-x]]

Attachment: bug1683328-esr91.patch

Patch moved to calendar-event-column.js in absence of bug 1731209 for esr91.

Comment 13

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9252067 [details] [diff] [review]
bug1683328-esr91.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Dragging to create or extend an event can end earlier than necessary if the user accidentally leave the view. Moreover, it is converted into a drag session, which can cause errors on dropping.
Testing completed (on c-c, etc.): No tests.
Risk to taking this patch (and alternatives if risky): Low risk.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9252067 [details] [diff] [review]
bug1683328-esr91.patch

[Triage Comment]
Approved for esr91

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 91.4.0:
https://hg.mozilla.org/releases/comm-esr91/rev/c17f4bf0bdf2