Crash in [@ OOM | large | NS_ABORT_OOM | nsTSubstring<T>::Append | mozilla::net::WebSocketChannelChild::RecvOnMessageAvailableInternal]
Categories
(Core :: Networking: WebSockets, defect, P2)
Tracking
()
People
(Reporter: aryx, Assigned: kershaw)
References
Details
(Keywords: crash, Whiteboard: [necko-triaged])
Crash Data
Attachments
(1 file)
Low volume, affects Firefox 82+, code got changed in bug 1660361 for Firefox 82.
Crash report: https://crash-stats.mozilla.org/report/index/c001fced-4901-4dcf-888a-a38380201104
MOZ_CRASH Reason: MOZ_CRASH(OOM)
Top 10 frames of crashing thread:
0 xul.dll NS_ABORT_OOM xpcom/base/nsDebugImpl.cpp:618
1 xul.dll nsTSubstring<char>::Append xpcom/string/nsTSubstring.cpp:830
2 xul.dll mozilla::net::WebSocketChannelChild::RecvOnMessageAvailableInternal netwerk/protocol/websocket/WebSocketChannelChild.cpp:298
3 xul.dll mozilla::net::WebSocketChannelChild::RecvOnMessageAvailable netwerk/protocol/websocket/WebSocketChannelChild.cpp:312
4 xul.dll mozilla::net::PWebSocketChild::OnMessageReceived ipc/ipdl/PWebSocketChild.cpp:416
5 xul.dll mozilla::dom::PContentChild::OnMessageReceived ipc/ipdl/PContentChild.cpp:8579
6 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2074
7 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1953
8 xul.dll mozilla::SchedulerGroup::Runnable::Run xpcom/threads/SchedulerGroup.cpp:146
9 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:515
|
Assignee | |
Comment 1•4 years ago
|
||
Well, after bug 1660361 the crash MOZ_CRASH("IPC message size is too large") in parent process is gone, but we got OOM crashes in child processes. I think crash in child process is a little bit better than parent process, so I think we should not revert the changes done in bug 1660361.
To fix this kind of issue once for all, we should move the logic in WebSocketChannel::ProcessInput to child process.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/259ad0fe9f08 Fail the websocket connection when there is no enough memory r=necko-reviewers,valentin
|
||
Comment 4•3 years ago
|
||
Backed out for build bustages.
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=259ad0fe9f086b96fc4c043481e019aab2d50126
Log: https://treeherder.mozilla.org/logviewer?job_id=324225045&repo=autoland&lineNumber=29029
Backout: https://hg.mozilla.org/integration/autoland/rev/2a84aafae9d989c9c585a4d04fa1f39c99f5e9a6
|
|
Assignee | |
Comment 5•3 years ago
|
||
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/084279c12a76 Fail the websocket connection when there is no enough memory r=necko-reviewers,valentin
|
||
Comment 7•3 years ago
•
|
||
Backed out for build bustage complaining about rules.mk.
Backout link: https://hg.mozilla.org/integration/autoland/rev/cb4913fddb0bc89c56a9bc6c71eec2b71c6e5d62
Failure log: https://treeherder.mozilla.org/logviewer?job_id=324444721&repo=autoland&lineNumber=57304
https://treeherder.mozilla.org/logviewer?job_id=324444707&repo=autoland&lineNumber=66584
|
|
Assignee | |
Comment 8•3 years ago
|
||
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1068ecdf3b83 Fail the websocket connection when there is no enough memory r=necko-reviewers,valentin
|
||
Comment 10•3 years ago
|
||
Backout by archaeopteryx@coole-files.de: https://hg.mozilla.org/mozilla-central/rev/4f9d4fa5a2ba Backed out changeset 084279c12a76 for build bustage complaining about rules.mk. CLOSED TREE
|
|
||
Comment 11•3 years ago
|
||
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e291934f11cc Fail the websocket connection when there is no enough memory r=necko-reviewers,valentin CLOSED TREE
|
||
Comment 12•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1068ecdf3b83
https://hg.mozilla.org/mozilla-central/rev/e291934f11cc
|
||
Comment 13•3 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
|
||
Updated•3 years ago
|
|
|
||
Comment 14•3 years ago
|
||
The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 15•3 years ago
|
||
This is an OOM, so I think we don't need to uplift this.
Description
•