Stop using CallNonGenericMethod for RegExp.prototype getters
Categories
(Core :: JavaScript: Standard Library, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 3 open bugs)
Details
Attachments
(1 file)
Similar to Bug 1651815 we should stop using CallNonGenericMethod here as well.
The RegExp case is a bit awkward because we have to handle the case where this
is %RegExp.prototype%
. I opted to implementing a common implementation that abstracts away most of the complexity. I am not sure if this is the best abstraction for this however. Only the case of RegExp.prototype.source returning "(?:)"
instead of undefined
makes it even bit more annoying.
Assignee | ||
Comment 1•4 years ago
|
||
This also implements an improved error message:
TypeError: RegExp.prototype.global getter called on non-RegExp object: Math
This is similar to Chromes' message:
RegExp.prototype.global getter called on non-RegExp object
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Backed out changeset 7cb103daaa8d (bug 1675240) for Atom related crashes.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a28bd283351b3b12beec3f63b3c7c3022322e36f
Failure log: https://treeherder.mozilla.org/logviewer?job_id=322592677&repo=autoland&lineNumber=6875
[task 2020-11-22T21:55:55.169Z] 21:55:55 INFO - TEST-START | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html
[task 2020-11-22T21:55:55.299Z] 21:55:55 INFO - GECKO(5864) | Console message: [JavaScript Warning: "The character encoding of a framed document was not declared. The document may appear different if viewed without the document framing it." {file: "http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html" line: 0}]
[task 2020-11-22T21:55:55.375Z] 21:55:55 INFO - GECKO(5864) | [Parent 5864, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4289
[task 2020-11-22T21:55:55.391Z] 21:55:55 INFO - GECKO(5864) | [Parent 5864, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1132
[task 2020-11-22T21:55:55.508Z] 21:55:55 INFO - GECKO(5864) | [Parent 5864, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.510Z] 21:55:55 INFO - GECKO(5864) | [Parent 5864, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.510Z] 21:55:55 INFO - GECKO(5864) | [Parent 5864, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.511Z] 21:55:55 INFO - GECKO(5864) | [Parent 5864, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.519Z] 21:55:55 INFO - GECKO(5864) | [Child 6025, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.520Z] 21:55:55 INFO - GECKO(5864) | [Child 6025, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.587Z] 21:55:55 INFO - GECKO(5864) | Console message: [JavaScript Warning: "Storage access automatically granted for origin “http://example.org” on “http://mochi.test:8888”."]
[task 2020-11-22T21:55:55.591Z] 21:55:55 INFO - GECKO(5864) | [Child 6025, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.592Z] 21:55:55 INFO - GECKO(5864) | [Child 6025, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.712Z] 21:55:55 INFO - GECKO(5864) | [Child 6025, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.714Z] 21:55:55 INFO - GECKO(5864) | [Child 6025, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2020-11-22T21:55:55.996Z] 21:55:55 INFO - GECKO(5864) | Hit MOZ_CRASH(*** Atom not marked for zone 0x7fb6e1ef1000 at argument 0) at /builds/worker/checkouts/gecko/js/src/vm/JSContext-inl.h:110
[task 2020-11-22T21:55:56.003Z] 21:55:56 INFO - GECKO(5864) | ExceptionHandler::GenerateDump cloned child 6265
[task 2020-11-22T21:55:56.004Z] 21:55:56 INFO - GECKO(5864) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2020-11-22T21:55:56.004Z] 21:55:56 INFO - GECKO(5864) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2020-11-22T21:55:56.132Z] 21:55:56 INFO - GECKO(5864) | Exiting due to channel error.
[task 2020-11-22T21:55:56.133Z] 21:55:56 INFO - GECKO(5864) | Exiting due to channel error.
[task 2020-11-22T21:55:56.133Z] 21:55:56 INFO - GECKO(5864) | Exiting due to channel error.
[task 2020-11-22T21:55:56.169Z] 21:55:56 INFO - TEST-INFO | Main app process: exit 11
[task 2020-11-22T21:55:56.170Z] 21:55:56 INFO - Buffered messages logged at 21:55:55
[task 2020-11-22T21:55:56.170Z] 21:55:56 INFO - add_task | Entering test test_content_script_cross_origin_frame
[task 2020-11-22T21:55:56.171Z] 21:55:56 INFO - Extension loaded
[task 2020-11-22T21:55:56.171Z] 21:55:56 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html | CS can access page DOM - Expected: Sample text, Actual: Sample text
[task 2020-11-22T21:55:56.171Z] 21:55:56 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html | undefined - Expected: 1.0, Actual: 1.0
[task 2020-11-22T21:55:56.172Z] 21:55:56 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html | undefined - Expected: Generated extension, Actual: Generated extension
[task 2020-11-22T21:55:56.172Z] 21:55:56 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html | sender frameId is ok
[task 2020-11-22T21:55:56.174Z] 21:55:56 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html | url is ok
[task 2020-11-22T21:55:56.174Z] 21:55:56 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html | CS runs in a shared Sandbox - Expected: 357, Actual: 357
[task 2020-11-22T21:55:56.174Z] 21:55:56 INFO - Buffered messages finished
[task 2020-11-22T21:55:56.174Z] 21:55:56 ERROR - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html | application terminated with exit code 11
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - runtests.py | Application ran for: 0:00:44.545295
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - zombiecheck | Reading PID log: /tmp/tmpP9w3b2pidlog
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - ==> process 5864 launched child process 5888
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - ==> process 5864 launched child process 6025
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - ==> process 5864 launched child process 6073
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - ==> process 5864 launched child process 6076
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - ==> process 5864 launched child process 6124
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - ==> process 5864 launched child process 6164
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - ==> process 5864 launched child process 6239
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - zombiecheck | Checking for orphan process with PID: 5888
[task 2020-11-22T21:55:56.175Z] 21:55:56 INFO - zombiecheck | Checking for orphan process with PID: 6025
[task 2020-11-22T21:55:56.176Z] 21:55:56 INFO - zombiecheck | Checking for orphan process with PID: 6124
[task 2020-11-22T21:55:56.176Z] 21:55:56 INFO - zombiecheck | Checking for orphan process with PID: 6164
[task 2020-11-22T21:55:56.177Z] 21:55:56 INFO - zombiecheck | Checking for orphan process with PID: 6073
[task 2020-11-22T21:55:56.178Z] 21:55:56 INFO - zombiecheck | Checking for orphan process with PID: 6076
[task 2020-11-22T21:55:56.179Z] 21:55:56 INFO - zombiecheck | Checking for orphan process with PID: 6239
[task 2020-11-22T21:55:56.180Z] 21:55:56 INFO - mozcrash Copy/paste: /builds/worker/fetches/minidump_stackwalk/minidump_stackwalk /tmp/tmpomvkUY.mozrunner/minidumps/341c6e15-2e41-ae47-4bcd-5c2ae6be1068.dmp /builds/worker/workspace/build/symbols
[task 2020-11-22T21:56:01.403Z] 21:56:01 INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/341c6e15-2e41-ae47-4bcd-5c2ae6be1068.dmp
[task 2020-11-22T21:56:01.403Z] 21:56:01 INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/341c6e15-2e41-ae47-4bcd-5c2ae6be1068.extra
[task 2020-11-22T21:56:01.557Z] 21:56:01 INFO - PROCESS-CRASH | toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html | application crashed [@ js::ContextChecks::checkAtom<JSAtom>(JSAtom*, int)]
[task 2020-11-22T21:56:01.558Z] 21:56:01 INFO - Mozilla crash reason: *** Atom not marked for zone 0x7fb6e1ef1000 at argument 0
[task 2020-11-22T21:56:01.558Z] 21:56:01 INFO - Crash dump filename: /tmp/tmpomvkUY.mozrunner/minidumps/341c6e15-2e41-ae47-4bcd-5c2ae6be1068.dmp
[task 2020-11-22T21:56:01.558Z] 21:56:01 INFO - Operating system: Linux
[task 2020-11-22T21:56:01.558Z] 21:56:01 INFO - 0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64
[task 2020-11-22T21:56:01.558Z] 21:56:01 INFO - CPU: amd64
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO - family 6 model 85 stepping 4
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO - 2 CPUs
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO -
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO - GPU: UNKNOWN
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO -
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO - Crash reason: SIGSEGV /SEGV_MAPERR
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO - Crash address: 0x0
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO - Process uptime: not available
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO -
[task 2020-11-22T21:56:01.559Z] 21:56:01 INFO - Thread 0 (crashed)
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - 0 libxul.so!void js::ContextChecks::checkAtom<JSAtom>(JSAtom*, int) [JSContext-inl.h:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 109 + 0x3d]
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - rax = 0x0000562c0dedbe70 rdx = 0x0000000000000000
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - rcx = 0x0000000000000b40 rbx = 0x0000562c0dedbe80
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - rsi = 0x00007fb6ff9af8b0 rdi = 0x00007fb6ff9ae680
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - rbp = 0x00007ffd24ee5150 rsp = 0x00007ffd24ee5130
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - r8 = 0x00007fb6ff9af8b0 r9 = 0x00007fb700916780
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - r10 = 0x0000000000000000 r11 = 0x0000000000000000
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - r12 = 0x00007ffd24ee5190 r13 = 0x00007ffd24ee5310
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - r14 = 0x0000000000000000 r15 = 0x000001689749a510
[task 2020-11-22T21:56:01.560Z] 21:56:01 INFO - rip = 0x00007fb6f2e6c4f9
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - Found by: given as instruction pointer in context
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - 1 libxul.so!CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 500 + 0x6a]
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5360 rbp = 0x00007ffd24ee51d0
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5160 r12 = 0x00007fb6e01e1000
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - r13 = 0x00007ffd24ee5310 r14 = 0x00007fb6e2e19000
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - r15 = 0x0000000024ee5101 rip = 0x00007fb6f2e5bb37
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - 2 libxul.so!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 590 + 0x12]
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - rbx = 0x00007ffd24ee51f0 rbp = 0x00007ffd24ee5270
[task 2020-11-22T21:56:01.561Z] 21:56:01 INFO - rsp = 0x00007ffd24ee51e0 r12 = 0x00007ffd24ee5310
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - r13 = 0x00007ffd24ee5500 r14 = 0x0000000000000000
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - r15 = 0x00007fb6f30cbe10 rip = 0x00007fb6f2e5b31a
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - 3 libxul.so!InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 643 + 0x10]
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5310 rbp = 0x00007ffd24ee52c0
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5280 r12 = 0x00007ffd24ee5360
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - r13 = 0x00007ffd24ee5500 r14 = 0x0000000000000000
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - r15 = 0x00007fb6e2e19000 rip = 0x00007fb6f2e5ca74
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - 4 libxul.so!js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 660 + 0xb]
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5310 rbp = 0x00007ffd24ee52f0
[task 2020-11-22T21:56:01.562Z] 21:56:01 INFO - rsp = 0x00007ffd24ee52d0 r12 = 0x00007ffd24ee5310
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - r13 = 0x00007ffd24ee5500 r14 = 0x00007fb6c4fc6170
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - r15 = 0x00007ffd24ee5470 rip = 0x00007fb6f2e5ccb0
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - 5 libxul.so!JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) [jsapi.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 2830 + 0x23]
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - rbx = 0x00007fb6e2e19000 rbp = 0x00007ffd24ee5450
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5300 r12 = 0x00007ffd24ee5310
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - r13 = 0x00007ffd24ee5500 r14 = 0x00007fb6c4fc6170
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - r15 = 0x00007ffd24ee5470 rip = 0x00007fb6f3437cab
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - 6 libxul.so!xpc::XrayWrapper<js::CrossCompartmentWrapper, xpc::JSXrayTraits>::get(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) const [XrayWrapper.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 2076 + 0x7b]
[task 2020-11-22T21:56:01.563Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5510 rbp = 0x00007ffd24ee5550
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5460 r12 = 0xfff9800000000000
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - r13 = 0x00007ffd24ee5500 r14 = 0x00007ffd24ee56a0
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - r15 = 0x00007ffd24ee54f0 rip = 0x00007fb6ef7379d8
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - 7 libxul.so!js::Proxy::getInternal(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) [Proxy.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 471 + 0x1c]
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5740 rbp = 0x00007ffd24ee5680
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5560 r12 = 0x00007ffd24ee56a0
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - r13 = 0x00007fb6e2e19000 r14 = 0x00007fb6f5490910
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - r15 = 0x00007ffd24ee58b0 rip = 0x00007fb6f2f7ef20
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.564Z] 21:56:01 INFO - 8 libxul.so!js::Proxy::get(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) [Proxy.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 479 + 0x16]
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5690 rbp = 0x00007ffd24ee56f0
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5690 r12 = 0x00007ffd24ee5740
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - r13 = 0xfff9800000000000 r14 = 0x00007fb6c4fc6170
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - r15 = 0x00007ffd24ee58b0 rip = 0x00007fb6f2f7eb3e
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - 9 libxul.so!js::Proxy::getInternal(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) [Proxy.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 467 + 0x18]
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5910 rbp = 0x00007ffd24ee5820
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5700 r12 = 0x00007ffd24ee5840
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - r13 = 0x00007fb6e2e19000 r14 = 0x00007ffd24ee5740
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - r15 = 0x00007ffd24ee58b0 rip = 0x00007fb6f2f7f03d
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - 10 libxul.so!js::Proxy::get(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) [Proxy.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 479 + 0x16]
[task 2020-11-22T21:56:01.565Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5830 rbp = 0x00007ffd24ee5890
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5830 r12 = 0x00007ffd24ee5910
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - r13 = 0xfff9800000000000 r14 = 0x00007fb6c4fc6170
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - r15 = 0x00007ffd24ee58b0 rip = 0x00007fb6f2f7eb3e
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - 11 libxul.so!js::GetProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, js::PropertyName*, JS::MutableHandle<JS::Value>) [ObjectOperations-inl.h:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 124 + 0x15]
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - rbx = 0x00007ffd24ee58a0 rbp = 0x00007ffd24ee58f0
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - rsp = 0x00007ffd24ee58a0 r12 = 0x00007ffd24ee5910
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - r13 = 0x00007fb6e2e19000 r14 = 0x00007fb6c4fc6170
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - r15 = 0x00007ffd24ee5930 rip = 0x00007fb6f2e6265d
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - 12 libxul.so!js::GetProperty(JSContext*, JS::Handle<JS::Value>, JS::Handle<js::PropertyName*>, JS::MutableHandle<JS::Value>) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 4640 + 0x10]
[task 2020-11-22T21:56:01.566Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5900 rbp = 0x00007ffd24ee5980
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5900 r12 = 0x00007ffd24ee5d70
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - r13 = 0xfffdffffffffffff r14 = 0x00007fb6c4fc6170
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - r15 = 0x00007ffd24ee5920 rip = 0x00007fb6f2e619c0
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - 13 libxul.so!Interpret(JSContext*, js::RunState&) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 2982 + 0x436]
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - rbx = 0x00000ee719327000 rbp = 0x00007ffd24ee5ea0
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5990 r12 = 0x00007fb6c4fc6170
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - r13 = 0xffff800000000000 r14 = 0x00007fb6c4fc60e0
[task 2020-11-22T21:56:01.567Z] 21:56:01 INFO - r15 = 0x00007ffd24ee5de0 rip = 0x00007fb6f2e4df68
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - 14 libxul.so!js::RunScript(JSContext*, js::RunState&) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 468 + 0xb]
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - rbx = 0x00007fb6ff320601 rbp = 0x00007ffd24ee5ef0
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5eb0 r12 = 0x00007fb6e2e19000
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - r13 = 0x00007fb6e1ec7961 r14 = 0x00007ffd24ee5f30
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - r15 = 0x0000000000000000 rip = 0x00007fb6f2e473e8
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - 15 libxul.so!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 615 + 0x5]
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - rbx = 0x00007ffd24ee5f10 rbp = 0x00007ffd24ee5f90
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5f00 r12 = 0x00007ffd24ee5f10
[task 2020-11-22T21:56:01.568Z] 21:56:01 INFO - r13 = 0x00007fb6e2e19000 r14 = 0x00007fb6e01e1000
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - r15 = 0x00007fb6e01e1000 rip = 0x00007fb6f2e5b2bd
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - 16 libxul.so!InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 643 + 0x10]
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - rbx = 0x00007ffd24ee6040 rbp = 0x00007ffd24ee5fe0
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5fa0 r12 = 0x00007ffd24ee6068
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - r13 = 0x00007ffd24ee6050 r14 = 0x0000000000000000
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - r15 = 0x00007fb6e2e19000 rip = 0x00007fb6f2e5ca74
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - 17 libxul.so!js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 660 + 0xb]
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - rbx = 0x00007ffd24ee6040 rbp = 0x00007ffd24ee6010
[task 2020-11-22T21:56:01.569Z] 21:56:01 INFO - rsp = 0x00007ffd24ee5ff0 r12 = 0x00007ffd24ee6280
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - r13 = 0x00007ffd24ee6050 r14 = 0x00007ffd24ee6280
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - r15 = 0x00007ffd24ee6020 rip = 0x00007fb6f2e5ccb0
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - 18 libxul.so!js::Call(JSContext*, JS::Handle<JS::Value>, JSObject*, JS::MutableHandle<JS::Value>) [Interpreter.h:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 98 + 0x19]
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - rbx = 0x00007ffd24ee6040 rbp = 0x00007ffd24ee60b0
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - rsp = 0x00007ffd24ee6020 r12 = 0x00007ffd24ee6280
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - r13 = 0x00007ffd24ee6050 r14 = 0x00007ffd24ee6280
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - r15 = 0x00007ffd24ee6020 rip = 0x00007fb6f2f6bee6
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - 19 libxul.so!MaybeCallMethod(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) [JSObject.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 2864 + 0x13]
[task 2020-11-22T21:56:01.570Z] 21:56:01 INFO - rbx = 0x00007ffd24ee6280 rbp = 0x00007ffd24ee6130
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - rsp = 0x00007ffd24ee60c0 r12 = 0x00007ffd24ee6158
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - r13 = 0x00007ffd24ee60e0 r14 = 0x00007ffd24ee60d0
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - r15 = 0x00007ffd24ee6200 rip = 0x00007fb6f316405c
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - 20 libxul.so!JS::OrdinaryToPrimitive(JSContext*, JS::Handle<JSObject*>, JSType, JS::MutableHandle<JS::Value>) [JSObject.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 2910 + 0x16]
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - rbx = 0x00000ee719327900 rbp = 0x00007ffd24ee61a0
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - rsp = 0x00007ffd24ee6140 r12 = 0x00007fb6f57d2ce8
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - r13 = 0x00007ffd24ee6158 r14 = 0x00007fb6e2e19000
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - r15 = 0x00007ffd24ee6200 rip = 0x00007fb6f31638ac
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.571Z] 21:56:01 INFO - 21 libxul.so!js::ToPrimitiveSlow(JSContext*, JSType, JS::MutableHandle<JS::Value>) [JSObject.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 3007 + 0x13]
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - rbx = 0x00007ffd24ee61e0 rbp = 0x00007ffd24ee6250
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - rsp = 0x00007ffd24ee61b0 r12 = 0x0000000000000003
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - r13 = 0x00007ffd24ee6200 r14 = 0xfff9800000000000
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - r15 = 0x00007ffd24ee6280 rip = 0x00007fb6f316465d
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - 22 libxul.so!JSString* js::ToStringSlow<(js::AllowGC)1>(JSContext*, js::MaybeRooted<JS::Value, (js::AllowGC)1>::HandleType) [StringType.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 2224 + 0x1b]
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - rbx = 0xfffe000000000000 rbp = 0x00007ffd24ee62b0
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - rsp = 0x00007ffd24ee6260 r12 = 0x00007ffd24ee62e8
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - r13 = 0x00007ffd24ee65a8 r14 = 0x00007ffd24ee6270
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - r15 = 0xfffa800000000000 rip = 0x00007fb6f328a3c8
[task 2020-11-22T21:56:01.572Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - 23 libxul.so!js::StringConstructor(JSContext*, unsigned int, JS::Value*) [String.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 3646 + 0x3a]
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - rbx = 0xffff800000000000 rbp = 0x00007ffd24ee6350
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - rsp = 0x00007ffd24ee62c0 r12 = 0x00007ffd24ee62e8
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - r13 = 0x00007ffd24ee65a8 r14 = 0x00007fb6e2e19000
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - r15 = 0xfffa800000000000 rip = 0x00007fb6f307ceaa
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - Found by: call frame info
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - 24 libxul.so!CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) [Interpreter.cpp:7cb103daaa8d249916f8e7c95a380c20434a9d41 : 498 + 0x12]
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - rbx = 0x00007ffd24ee68c0 rbp = 0x00007ffd24ee63d0
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - rsp = 0x00007ffd24ee6360 r12 = 0x00007fb6e01e1000
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - r13 = 0x00007ffd24ee65a8 r14 = 0x00007fb6e2e19000
[task 2020-11-22T21:56:01.573Z] 21:56:01 INFO - r15 = 0x00007fb6f307cc60 rip = 0x00007fb6f2e5bac2
[task 2020-11-22T21:56:01.574Z] 21:56:01 INFO - Found by: call frame info
...
...
...
Comment 5•4 years ago
•
|
||
The following seem to start perma failing with the backed out changes:
https://treeherder.mozilla.org/logviewer?job_id=322592596&repo=autoland&lineNumber=4159
https://treeherder.mozilla.org/logviewer?job_id=322606329&repo=autoland&lineNumber=2812
https://treeherder.mozilla.org/logviewer?job_id=322596590&repo=autoland&lineNumber=16948
Assignee | ||
Comment 6•4 years ago
|
||
We have to mark cross-compartment JSAtoms in the source getter.
Comment 8•4 years ago
|
||
bugherder |
Comment 9•4 years ago
|
||
== Change summary for alert #27906 (as of Wed, 02 Dec 2020 06:41:34 GMT) ==
Improvements:
Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|---|
5% | build times | windows2012-64-shippable | nightly taskcluster-m5d.4xlarge | 1,910.55 -> 1,808.20 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27906
Description
•