1675277 - Enable labeled metrics for the C++ and JS API of FOG

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Jan-Erik Rediger [:janerik]]

Labeled metrics are a bit of the odd ones because they are generic and wrap another metric.
We might need some special handling to allow their build-time maps to work and for lookup to work when used through the C++ or JS API.

This bug is about investigating the proper way to just that.

Labeled metrics are already organized by sub-metric type. That should be easier to support.

Comment 1

[Chris H-C :chutten]

ni?janerik for reviewing the proposal for how I intend to deal with this: https://docs.google.com/document/d/1mBURHOsK4QfcvxEXoFFeGXOkh7ou6XDl4M2H4NxfZyE/edit#

Comment 2

[Jan-Erik Rediger [:janerik]]

I think this can work, so r+ from my side on that.

Comment 3

[Chris H-C :chutten]

Attachment: Bug 1675277 - Adjust FOG Labeled metric to get FOG submetrics r?janerik!

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1675277 - Add a few test labeled metrics to FOG r?janerik!

Depends on D103229

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1675277 - Expose Labeled Metric APIs on FOG MLA FFI r?janerik!

Depends on D103230

Comment 6

[Chris H-C :chutten]

Attachment: Bug 1675277 - Remove is_implemented_type. All types implemented r?janerik!

Depends on D103231

Comment 7

[Chris H-C :chutten]

Attachment: Bug 1675277 - Support FOG Labeled Metrics in C++ and JS r?janerik!

Depends on D103232

Comment 8

[Chris H-C :chutten]

Attachment: Bug 1675277 - Update the FOG pytest expected files r?janerik!

Depends on D103233

Comment 9

[Chris H-C :chutten]

Attachment: Bug 1675277 - Documentation Updates for how to add new Labeled Metrics to FOG r?janerik!

Depends on D103341

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16d336a73f06
Adjust FOG Labeled metric to get FOG submetrics r=janerik
https://hg.mozilla.org/integration/autoland/rev/301eedc3ffab
Add a few test labeled metrics to FOG r=janerik
https://hg.mozilla.org/integration/autoland/rev/0b5dfb464b13
Expose Labeled Metric APIs on FOG MLA FFI r=janerik
https://hg.mozilla.org/integration/autoland/rev/6197ea596f43
Remove is_implemented_type. All types implemented r=janerik
https://hg.mozilla.org/integration/autoland/rev/20812d46b602
Support FOG Labeled Metrics in C++ and JS r=janerik
https://hg.mozilla.org/integration/autoland/rev/be615b1712c2
Update the FOG pytest expected files r=janerik
https://hg.mozilla.org/integration/autoland/rev/b07e2da0c034
Documentation Updates for how to add new Labeled Metrics to FOG r=janerik

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/16d336a73f06
https://hg.mozilla.org/mozilla-central/rev/301eedc3ffab
https://hg.mozilla.org/mozilla-central/rev/0b5dfb464b13
https://hg.mozilla.org/mozilla-central/rev/6197ea596f43
https://hg.mozilla.org/mozilla-central/rev/20812d46b602
https://hg.mozilla.org/mozilla-central/rev/be615b1712c2
https://hg.mozilla.org/mozilla-central/rev/b07e2da0c034