Closed Bug 1675277 Opened 4 months ago Closed 22 days ago

Enable labeled metrics for the C++ and JS API of FOG

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: janerik, Assigned: chutten)

References

Details

(Whiteboard: [telemetry:fog:m6])

Attachments

(7 files)

Labeled metrics are a bit of the odd ones because they are generic and wrap another metric.
We might need some special handling to allow their build-time maps to work and for lookup to work when used through the C++ or JS API.

This bug is about investigating the proper way to just that.

Labeled metrics are already organized by sub-metric type. That should be easier to support.

Assignee: jrediger → nobody
Priority: P1 → P3
Blocks: 1642646, 1662858
Assignee: nobody → chutten
Status: NEW → ASSIGNED
Priority: P3 → P1

ni?janerik for reviewing the proposal for how I intend to deal with this: https://docs.google.com/document/d/1mBURHOsK4QfcvxEXoFFeGXOkh7ou6XDl4M2H4NxfZyE/edit#

Flags: needinfo?(jrediger)

I think this can work, so r+ from my side on that.

Flags: needinfo?(jrediger)
See Also: → 1688281

Depends on D103233

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16d336a73f06
Adjust FOG Labeled metric to get FOG submetrics r=janerik
https://hg.mozilla.org/integration/autoland/rev/301eedc3ffab
Add a few test labeled metrics to FOG r=janerik
https://hg.mozilla.org/integration/autoland/rev/0b5dfb464b13
Expose Labeled Metric APIs on FOG MLA FFI r=janerik
https://hg.mozilla.org/integration/autoland/rev/6197ea596f43
Remove is_implemented_type. All types implemented r=janerik
https://hg.mozilla.org/integration/autoland/rev/20812d46b602
Support FOG Labeled Metrics in C++ and JS r=janerik
https://hg.mozilla.org/integration/autoland/rev/be615b1712c2
Update the FOG pytest expected files r=janerik
https://hg.mozilla.org/integration/autoland/rev/b07e2da0c034
Documentation Updates for how to add new Labeled Metrics to FOG r=janerik
You need to log in before you can comment on or make changes to this bug.