Closed Bug 1675285 Opened 7 months ago Closed 7 months ago

OpenPGP: Composer key status should list undecided/rejected keys

Categories

(MailNews Core :: Security: OpenPGP, defect, P1)

Tracking

(thunderbird_esr78+ fixed, thunderbird83 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
thunderbird_esr78 + fixed
thunderbird83 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This is a regression, first seen in 78.3.3, caused by rewritten code in bug 1665497.

Import a key for a correspondent.
Keep the key in acceptance status "undecided".
Compose an email to that correspondent.
Click the security button to get the security info.

Actual behavior:
The dialog claims "no key available".

Expected behavior, seen with 78.3.2 and earlier:
The dialog should say "no accepted key".

This is particularly confusing after using the security info dialog to discover and import a key (and forgetting to immediately accept it). After import, the dialog still claims "no key available", which gives the false impression that importing failed.

Severity: -- → S3
Priority: -- → P1

To fix this function getMultValidKeysForOneRecipient must include keys with acceptance undecided 0 and rejected -1.

Also, function isValidKeyForRecipient should not return early for status 0 and -1, the encryption key availability check should be done in these scenarios, too.

I'm moving one of the checks further up, as it avoid an unnecessary database access in some scenarios.

Keywords: regression
Status: NEW → ASSIGNED
Target Milestone: --- → 84 Branch

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/0f7059e35814
OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED

Comment on attachment 9185714 [details]
Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

[Approval Request Comment]
Regression caused by (bug #): 1665497
User impact if declined: misleading user interface
Testing completed (on c-c, etc.): manually
Risk to taking this patch (and alternatives if risky): low

Attachment #9185714 - Flags: approval-comm-beta?

Comment on attachment 9185714 [details]
Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

[Triage Comment]
Approved for beta

Attachment #9185714 - Flags: approval-comm-beta? → approval-comm-beta+
Duplicate of this bug: 1675007

Comment on attachment 9185714 [details]
Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

[Approval Request Comment]
Regression caused by (bug #): 1665497
User impact if declined: misleading user interface
Testing completed (on c-c, etc.): manually
Risk to taking this patch (and alternatives if risky): low

Attachment #9185714 - Flags: approval-comm-esr78?

Comment on attachment 9185714 [details]
Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

[Triage Comment]
Approved for esr78

Attachment #9185714 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.