1675285 - OpenPGP: Composer key status should list undecided/rejected keys

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect, P1)

Description

[Kai Engert [:KaiE:]]

This is a regression, first seen in 78.3.3, caused by rewritten code in bug 1665497.

Import a key for a correspondent.
Keep the key in acceptance status "undecided".
Compose an email to that correspondent.
Click the security button to get the security info.

Actual behavior:
The dialog claims "no key available".

Expected behavior, seen with 78.3.2 and earlier:
The dialog should say "no accepted key".

This is particularly confusing after using the security info dialog to discover and import a key (and forgetting to immediately accept it). After import, the dialog still claims "no key available", which gives the false impression that importing failed.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

Comment 2

[Kai Engert [:KaiE:]]

To fix this function getMultValidKeysForOneRecipient must include keys with acceptance undecided 0 and rejected -1.

Also, function isValidKeyForRecipient should not return early for status 0 and -1, the encryption key availability check should be done in these scenarios, too.

I'm moving one of the checks further up, as it avoid an unnecessary database access in some scenarios.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0f7059e35814
OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig DONTBUILD

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9185714 [details]
Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

[Approval Request Comment]
Regression caused by (bug #): 1665497
User impact if declined: misleading user interface
Testing completed (on c-c, etc.): manually
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9185714 [details]
Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 83.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/264083e41868

Comment 8

[Kai Engert [:KaiE:]]

Comment on attachment 9185714 [details]
Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

[Approval Request Comment]
Regression caused by (bug #): 1665497
User impact if declined: misleading user interface
Testing completed (on c-c, etc.): manually
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9185714 [details]
Bug 1675285 - OpenPGP: Composer key status should list undecided/rejected keys. r=PatrickBrunschwig

[Triage Comment]
Approved for esr78

Comment 10

[Kai Engert [:KaiE:]]

78.5.0
https://hg.mozilla.org/releases/comm-esr78/rev/d2373639e30fcf38ec44ffa01dc46b6859f2d566