1675417 - clang-tidy fails with color codes in LLVM trunk

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[(Away)]

https://github.com/llvm/llvm-project/commit/a07a2c88d96cc48d7d381a0300565090c24b9770 enabled color in clang-tidy

As a result, we get output like:

bugprone-argument-comment.cpp:3:19: note: 'y' declared here

(There are 0x1B ESC characters in there, but I don't think they will appear in Bugzilla. Here's a try log: https://firefoxci.taskcluster-artifacts.net/KWD1xgynTYOISddiLxXOBQ/0/public/logs/live_backing.log)

And so the regex that looks for error messages fails to find them: https://searchfox.org/mozilla-central/rev/c938c7416c633639a5c8ce4412be586eefb48005/python/mozbuild/mozbuild/code_analysis/mach_commands.py#2395

Andi, is this something that you would be able to look at?

Comment 1

[Andi [:andi]]

Attachment: Bug 1675417 - static-analysis autotest for `clang-tidy` should filter out colours.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/110e246ebc01
static-analysis autotest for `clang-tidy` should filter out colours. r=sylvestre

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/110e246ebc01