1675456 - Enable watcher for webextension toolboxes

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

The watcher is currently enabled for the content toolbox (localTab) and the MultiProcess Browser Toolbox. We should also start the watcher for webextension toolboxes.

Comment 1

[Alexandre Poirot [:ochameau]]

I'll give it a try.

Comment 2

[Alexandre Poirot [:ochameau]]

Doesn't work out of the box:
https://treeherder.mozilla.org/jobs?repo=try&revision=d2df12f3a33fa934b8959a3e9050f73e3e4bc7b5

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1675456 - Enable watcher for webextension toolboxes.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1675456 - [devtools] Enable watcher for webextension toolboxes.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1675456 - Ensure creating root browser element for webextension only once

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1675456 - WebExt browser elements workaround

Fix issues with webextension spawning a special browser element with children browser element having distinct browserId.
This mess up with the browserId filtering done in the content process...
All/Many addons are running in the same process and the root browser element is not bound to any one in particular??

Comment 8

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=769838312c0a1529e66b489939dfc141a445a88f

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1675456 - [devtools] Support reloading the current document debugged for a WebExtension.

Without this, the webconsole fails to execute anything after reloading the add-on document.
Can reproduce by running location.reload() in the console.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7950d8e5bc99
[devtools] Enable watcher for webextension toolboxes. r=nchevobbe,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/162a9da3f9b2
[devtools] Support reloading the current document debugged for a WebExtension. r=nchevobbe

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7950d8e5bc99
https://hg.mozilla.org/mozilla-central/rev/162a9da3f9b2