1675567 - Notify onResultPicked to all types of add-on Urlbar Providers

Status: NEW

(Firefox :: Address Bar, task, P2)

Description

[Mark Banner (:standard8)]

Currently onResultPicked is only notified to extension urlbar providers for tips and dynamic results.

For experiments it would be useful if the extension could be notified of the result being picked. For example, this would allow extra telemetry specific for the experiment to be easily added.

Comment 1

[Mark Banner (:standard8)]

Note: we possibly want to extend this with the details of the selection, e.g. click/entry, index etc, so that we could potentially log similar details to the in-browser telemetry (but extended).

Comment 2

[Harry Twyford]

Attachment: Bug 1675567 - Call pickResult for all types of UrlbarProviders. r?adw!

Well this is embarassing. I read this bug way too fast and implemented it the wrong way. This patch calls pickResult for every UrlbarProvider, rather than calling onResultPicked for every add-on provider. I'm posting this because it's already written and might be useful? Seeing as add-on providers are deprecated, the bug as reported probably doesn't make sense to implement. If we don't want this in-tree, I can just abandon the revision and close or P5 the bug.

Comment 3

[Harry Twyford]

EDIT: This comment was just duplicating the message above :)

Comment 4

[Drew Willcoxon :adw]

Mark, given that add-on experiments have been deprecated, is there still a use case for this?

Comment 5

[Mark Banner (:standard8)]

(In reply to Drew Willcoxon :adw from comment #4)

Mark, given that add-on experiments have been deprecated, is there still a use case for this?

I think if it is potentially useful for other address bar provider projects it might be worth keeping - but I don't know what all the plans are there.

Comment 6

[Drew Willcoxon :adw]

I don't think Quick Suggest needs this anymore, so I'll remove the dependency. If it turns out it does need it, then bug 1692518 is the new meta bug this should block.

Comment 7

[Drew Willcoxon :adw]

Bug 1694315 may have made this unnecessary.