1675622 - Show tab-to-search onboarding results more frequently in Firefox 83

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Harry Twyford]

I discovered bug 1675611 today, which will significantly limit the number of times we show tab-to-search onboarding results. The problem is that we count each keystroke as an impression. It's too late to properly fix that bug for 83, so Product and UX have asked we tweak the number of times we show these onboarding results to ensure users actually see them. We're going to go with 20x per session and 60x total.

[Tracking Requested - why for this release]:
This is a late uplift, but there will be no changes to user-facing code. Instead, we'll just be tweaking a pref that controls the number of times an onboarding message is shown, so this is very low-risk.

Comment 1

[Harry Twyford]

https://treeherder.mozilla.org/jobs?repo=try&revision=6a654d09807cc533f065a7e98822a02b66e38905

Comment 2

[Harry Twyford]

Attachment: Bug 1675622 - Show tab-to-search onboarding results more frequently in Firefox 83. r?adw,mak

Comment 3

[Harry Twyford]

Comment on attachment 9186108 [details]
Bug 1675622 - Show tab-to-search onboarding results more frequently in Firefox 83. r?adw,mak

Beta/Release Uplift Approval Request

• User impact if declined: Users will not see tab-to-search onboarding results frequently enough. It will be very easy to miss them.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch changes two hidden prefs that control the frequency of an onboarding message. There are no changes to the message, or any other user-facing code. We designed the frequency controls to be prefs for this kind of situation, so it's been considered. I tested the fix in a local build.

I'm requesting uplift before this lands since I'm hoping it can be landed by my reviewer overnight my time if it is r+'d. Please disregard this uplift request until this patch lands.

• String changes made/needed:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f609549255b3
Show tab-to-search onboarding results more frequently in Firefox 83. r=mak

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f609549255b3

Comment 6

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9186108 [details]
Bug 1675622 - Show tab-to-search onboarding results more frequently in Firefox 83. r?adw,mak

Approved for the beta branch before the merge, thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Landed for 83.0b10.
https://hg.mozilla.org/releases/mozilla-beta/rev/040da1001430

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

Closing this as verified fixed, as there were no changes done to UI side or behavior wise. This has been tested extensively with the release of Fx 83.