Closed Bug 1675624 Opened 3 months ago Closed 2 months ago

Ensure we persist search engine metadata between locale changes

Categories

(Firefox :: Search, defect, P1)

Firefox 82
defect

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: johnmarka, Assigned: daleharvey)

References

(Regressed 1 open bug)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

In UK locale (I understand the dictionary may differ, or the bug may not occur, in another locale), start firefox. Use options to remove "Chambers UK" from the one-click search engines, close and restart firefox.

Actual results:

"Chambers UK" dictionary added back in to the one-click search engines list.

Expected results:

No explicitly removed search engine should be added.

N.B. I'm classing this as a "defect" rather than "enhancement request" because it's silently undoing an explicitly changed setting.

Amending the subject, because that's indeed a search engine (a dictionary is a separate type of add-on used for spell-checking).

Removed default search engines are only hidden, not completely removed. Having said that, it shouldn't show up at every reboot.

Component: Untriaged → Search
Summary: Dictionary added as search engine every reboot → Chambers UK added as search engine every reboot

Hi,

Which Linux distribution are you using? Do you use a user.js file?

Could you attach some troubleshooting information that might help us figure out the issue? To do this, go to Help -> Troubleshooting Information, then Copy test to clipboard. You can paste that into an attachment using the attach new file button just above your first comment.

Flags: needinfo?(johnmarka)

(In reply to Mark Banner (:standard8) from comment #2)

Which Linux distribution are you using? Do you use a user.js file?

 $ uname -a
Linux GraceHopper 5.4.0-52-generic #57-Ubuntu SMP Thu Oct 15 10:57:00 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.1 LTS
Release:	20.04
Codename:	focal

No user.js file

Could you attach some troubleshooting information that might help us figure out the issue? To do this, go to Help -> Troubleshooting Information, then Copy test to clipboard. You can paste that into an attachment using the attach new file button just above your first comment.

Attaching now

N.B. this has been discussed before elsewhere, so I'm pretty sure it's not just me: https://www.reddit.com/r/firefox/comments/bit0ns/chambers_search_engine_added_not_sure_how/

Flags: needinfo?(johnmarka)

I also remember seeing this on Windows, but I don't have a Windows machine in front of me right now to double check

See Also: → 1546652
See Also: 1546652

If I understand the referenced bug correctly, this is because the official "English (GB) Language Pack" add-on (which I assume is automatically installed because of my locale) installs the dictionary as a search engine.

So, to differentiate this issue from the more generic one of add-ons which install search engines:

Please can automatically installed language packs NOT install search engines. It's not a core feature of a language pack. At all.

Plus, there are many different dictionaries people might want to use, "Chambers UK" is essentially unknown and certainly nowhere near a universal standard implied by the locale.

(In reply to johnmarka from comment #6)

Please can automatically installed language packs NOT install search engines. It's not a core feature of a language pack. At all.

Plus, there are many different dictionaries people might want to use, "Chambers UK" is essentially unknown and certainly nowhere near a universal standard implied by the locale.

We use a combination of locale and region to determine which search engines are appropriate for users as defaults. Language packs do change Firefox's locale, so this can affect the search engines installed. However language packs themselves do not contain engines which is why I removed bug 1546652 from the references as it is not actually anything to do with this bug.

I will note that we are currently looking into this as we have had some other similar reports.

Depends on: 1677135

Ok so been investigating this, a few interrelated bugs happening here, on shutdown we are seeing the language pack being unregistered which is causing the locale to change changes from en-GB to the default (en-US), when we switch to en-US chambers is no longer an active engine so we stop storing the metadata about it (the place where we mark it as deleted), then on next startup we are in en-GB again, load up chambers but the flag saying it had been deleted was missing

We shouldnt see the locale change on shutdown, and even if we did we have a guard against maybeReloadEngines in shutdown that is failing so that is being looked at in 1677135.

Seperately even if the user switched locales we probably want to maintain the deleted metadata so that persists if the user switches back, so I will do that in this bug.

Assignee: nobody → dharvey
Summary: Chambers UK added as search engine every reboot → Ensure we persist search engine metadata between locale changes
Severity: -- → S3
Priority: -- → P1
Duplicate of this bug: 1675860
Duplicate of this bug: 1675993
Duplicate of this bug: 1676838
Duplicate of this bug: 1675994
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90a4b1d0082a
Persist engine metadata for inactive AppProvided engines r=Standard8

(In reply to johnmarka from comment #5)

I also remember seeing this on Windows, but I don't have a Windows machine in front of me right now to double check

I have Windows 10 pro 10H2 and there: FF 82.0.2 /82.0.3 / 83.0 . This versions do not have the fault - its only in Linux 8Ubuntu 20.04 / Manjaro

(In reply to johnmarka from comment #5)

I also remember seeing this on Windows, but I don't have a Windows machine in front of me right now to double check

I have Windows 10 pro 20H2 (latest) and tested there: FF 82.0.2 /82.0.3 / 83.0 .
This versions do not have the fault - its only in Linux (Ubuntu 20.04 / Manjaro)

ok this test failure was down to a test not waiting for itself to finish cleaning up properly

Only oranges here are unrelated as far as I can tell so going to reland, https://treeherder.mozilla.org/jobs?repo=try&revision=ecfd4aa2845dd2bcb793a2f70d8c455704ec742e&selectedTaskRun=OAb9STL9QCC6fKgQ8dGH2A.0

Flags: needinfo?(dharvey)
Attachment #9188255 - Attachment description: Bug 1675624 - Persist engine metadata for inactive AppProvided engines → Bug 1675624 - Persist engine metadata for inactive AppProvided engines r=Standard8
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1398009ebbc0
Persist engine metadata for inactive AppProvided engines r=Standard8
Status: UNCONFIRMED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Regressions: 1680649
Duplicate of this bug: 1668484
You need to log in before you can comment on or make changes to this bug.