1676079 - Make marker type names consistent, with "Marker" suffix

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Follow-up to https://phabricator.services.mozilla.com/D96043#inline-542326
Most marker type definitions end with "Marker", e.g. DOMEventMarker.
The main advantage, is that it's easier to distinguish them from non-profiler data structures in editors and in code browsers like Searchfox. E.g., DOMEvent may give the idea that this is a DOM event itself, when it's really a profiler marker about DOM events.

However some marker types don't say "Marker", like NoPayload or Text.
There are defined in the baseprofiler::markers namespace, so I initially thought that that would be enough to identify them as markers.

But the namespace may not always be explicit or obvious.
Also, for consistency it would be good to use the same suffix everywhere.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1676079 - For consistency and clarity, add Marker suffix to all marker types - r?gregtatum

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99aa3dc8e185
For consistency and clarity, add Marker suffix to all marker types - r=gregtatum

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/99aa3dc8e185