1676414 - Perma browser/base/content/test/keyboard/browser_bookmarks_shortcut.js | Uncaught exception - at resource://testing-common/BrowserTestUtils.jsm:1294 - TypeError: popup is null when Gecko 84 merges to Beta on 2020-11-16

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Regression from bug 1675549?

central-as-beta simulation
Failure log

[task 2020-11-10T14:20:34.919Z] 14:20:34     INFO - TEST-PASS | browser/base/content/test/keyboard/browser_bookmarks_shortcut.js | bookmarks toolbar is visible - 
[task 2020-11-10T14:20:34.920Z] 14:20:34     INFO - Test that the toolbar menuitem state is correct.
[task 2020-11-10T14:20:34.920Z] 14:20:34     INFO - Opening context menu.
[task 2020-11-10T14:20:34.921Z] 14:20:34     INFO - Buffered messages finished
[task 2020-11-10T14:20:34.922Z] 14:20:34     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/keyboard/browser_bookmarks_shortcut.js | Uncaught exception - at resource://testing-common/BrowserTestUtils.jsm:1294 - TypeError: popup is null
[task 2020-11-10T14:20:34.923Z] 14:20:34     INFO - Stack trace:
[task 2020-11-10T14:20:34.923Z] 14:20:34     INFO - waitForPopupEvent@resource://testing-common/BrowserTestUtils.jsm:1294:9
[task 2020-11-10T14:20:34.924Z] 14:20:34     INFO - openContextMenu@chrome://mochitests/content/browser/browser/base/content/test/keyboard/browser_bookmarks_shortcut.js:130:26
[task 2020-11-10T14:20:34.925Z] 14:20:34     INFO - Leaving test bound testBookmarksToolbarShortcut

Comment 1

[:Gijs (he/him)]

You can reproduce locally with:

./mach mochitest browser/base/content/test/keyboard/browser_bookmarks_shortcut.js --setpref 'browser.toolbars.bookmarks.2h2020=false'

It looks like this is because the test expects a submenu for the bookmarks toolbar, and we don't use a submenu when the pref is false.

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1676414 - Fix permafail for bookmarks shortcut. r?jaws,Gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d93ec1fdb25
Fix permafail for bookmarks shortcut. r=jaws

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2d93ec1fdb25

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's central-as-beta simulation.