1676417 - Perma browser/components/places/tests/browser/browser_autoshow_bookmarks_toolbar.js | Uncaught exception - Toolbar should be shown. - timed out after 50 tries. when Gecko 84 merges to Beta on 2020-11-16

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation
Failure log

[task 2020-11-10T14:21:05.615Z] 14:21:05     INFO - TEST-PASS | browser/components/places/tests/browser/browser_autoshow_bookmarks_toolbar.js | Bookmarks toolbar should start out collapsed. - true == true - 
[task 2020-11-10T14:21:05.615Z] 14:21:05     INFO - Buffered messages logged at 14:21:00
[task 2020-11-10T14:21:05.615Z] 14:21:05     INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-10T14:21:05.616Z] 14:21:05     INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-10T14:21:05.616Z] 14:21:05     INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-10T14:21:05.617Z] 14:21:05     INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-10T14:21:05.617Z] 14:21:05     INFO - Buffered messages finished
[task 2020-11-10T14:21:05.618Z] 14:21:05     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_autoshow_bookmarks_toolbar.js | Uncaught exception - Toolbar should be shown. - timed out after 50 tries.
[task 2020-11-10T14:21:05.618Z] 14:21:05     INFO - Leaving test bound test_new_on_toolbar

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1676417 - fix use of 2020h2 bookmarks pref in the default location pref getter in PlacesUIUtils to unbreak beta tests, r?jaws

The browser_autoshow_bookmarks_toolbar.js test pushPrefEnv's the 2020h2 pref,
but because the getter for the default location of bookmarks caches the pref
value for the default location, and doesn't update when the 2020h2 pref
changes, we continue returning the 'unfiled' folder from the pref getter if
the getter has been previously accessed (e.g. when the tests are run in a
directory).

To fix this, decouple the check for the 2020h2 pref from the preference
getter for the default location.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3281939949e
fix use of 2020h2 bookmarks pref in the default location pref getter in PlacesUIUtils to unbreak beta tests, r=jaws

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d3281939949e

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's central-as-beta simulation.