Closed Bug 1674515 Opened 11 months ago Closed 11 months ago

Show the bookmarks toolbar when creating a new bookmark in the toolbar

Categories

(Firefox :: Bookmarks & History, defect, P1)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1219788 we made the bookmarks toolbar show up if users changed the location of a bookmark to be the bookmark toolbar.

This was implemented using a callback that is invoked when the selected folder in the panel / dialog changes.

After the changes in bug 1665389, it will be possible (in fact, it will be the default, on new profiles!) for bookmarks to start off on the bookmarks toolbar - that is, when a user bookmarks, that new bookmark will already be on the toolbar.

The logic from bug 1219788 is only invoked when the folder is changed, so it won't be invoked in this case, meaning we won't show the bookmarks toolbar.

After the changes in bug 727668, the showing of the bookmarks toolbar is only temporary - the toolbar disappears again when the user navigates or switches tabs.

I'm pretty sure that we want to continue doing what we started in bug 1219788 which is to show the toolbar when a bookmark is created directly on the toolbar.

What I'm less sure about is what we should be doing if e.g. the user edits an existing bookmark that's already on the toolbar. Should we still show the toolbar? I'm not sure if this makes sense or not...

From conversations with UX folks: we want to show the toolbar when creating bookmarks on the toolbar, or when moving a bookmark there while editing the bookmark (which we already do) -- but not when opening an editing panel from the star icon to edit a bookmark already on the toolbar.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Summary: Decide when to show the bookmarks toolbar for bookmarks that start off in the bookmarks toolbar → Show the bookmarks toolbar when creating a new bookmark in the toolbar
Severity: -- → S3
Priority: -- → P1
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ca520bfdc084
show the bookmarks toolbar when creating a bookmark there, r=jaws

Backed out for failures on browser_autoshow_bookmarks_toolbar.js

backout: https://hg.mozilla.org/integration/autoland/rev/35fa44297d18d355957bb2e9c2dc344e9ef0f9ef

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=ca520bfdc084e937b5889ec5687ca36be65dc8f0&group_state=expanded&selectedTaskRun=MNaiA4xBSmC8wEyJw3RtIg.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=321209113&repo=autoland&lineNumber=5838

[task 2020-11-09T17:07:30.634Z] 17:07:30 INFO - TEST-PASS | browser/components/places/tests/browser/browser_autoshow_bookmarks_toolbar.js | Bookmarks toolbar should start out collapsed. - true == true -
[task 2020-11-09T17:07:30.635Z] 17:07:30 INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-09T17:07:30.637Z] 17:07:30 INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-09T17:07:30.638Z] 17:07:30 INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-09T17:07:30.639Z] 17:07:30 INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-09T17:07:30.640Z] 17:07:30 INFO - Buffered messages finished
[task 2020-11-09T17:07:30.641Z] 17:07:30 INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_autoshow_bookmarks_toolbar.js | Test timed out -
[task 2020-11-09T17:07:30.750Z] 17:07:30 INFO - GECKO(2951) | MEMORY STAT | vsize 3337MB | residentFast 351MB | heapAllocated 102MB
[task 2020-11-09T17:07:30.752Z] 17:07:30 INFO - TEST-OK | browser/components/places/tests/browser/browser_autoshow_bookmarks_toolbar.js | took 90410ms

Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5d8fba30a3f4
show the bookmarks toolbar when creating a bookmark there, r=jaws
Flags: needinfo?(gijskruitbosch+bugs)
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Regressions: 1713471
You need to log in before you can comment on or make changes to this bug.