1676657 - Resurrect paint phase weight histograms and port them to WebRender

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P2)

Description

[Miko Mynttinen]

This bug is about fixing CONTENT_LARGE_PAINT_PHASE_WEIGHT and CONTENT_SMALL_PAINT_PHASE_WEIGHT histograms (expired in FF72) so that they work with WebRender frame scheduling. Because I am changing the histogram keys to be WR specific, they will be renamed to CONTENT_LARGE_PAINT_PHASE_WEIGHT_2 and CONTENT_SMALL_PAINT_PHASE_WEIGHT_2.

The goal of these probes is to get an idea how the different phases of our rendering pipeline perform in the real world, which helps us to target optimization work.

Comment 1

[Miko Mynttinen]

Attachment: Bug 1676657 - Port paint phase weight histograms to WebRender r=nical

Comment 2

[Miko Mynttinen]

Attachment: renewal_request.md

Comment 3

[Chris H-C :chutten]

Comment on attachment 9208479 [details]
renewal_request.md

For moving from an expiring to a permanent data collection, please use the complete Data Review Request form (so we can properly document the individual who's responsible for the permanent collection)

Comment 4

[Miko Mynttinen]

Attachment: renewal_request.md

Comment 5

[Chris H-C :chutten]

Comment on attachment 9209526 [details]
renewal_request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Miko Mynttinen is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for pre-release channels only.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 6

[Miko Mynttinen]

I think this is a good opportunity to collect some more data about the differences between incremental and full paints, because they can be very different. For example, retained display lists make updating the display list after cursor blinks very cheap, while WebRender display list still needs to iterate through the full content of Gecko display list.

In other words, this is simply further splitting the current data based on display list build type (partial or full).

Comment 7

[Miko Mynttinen]

Attachment: request.md

Updated request with two new histograms.

Comment 8

[Chris H-C :chutten]

Comment on attachment 9216400 [details]
request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Miko Mynttinen is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for pre-release channels only.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca4d87f2ec7b
Port paint phase weight histograms to WebRender r=nical

Comment 10

[Alexandru Michis [:malexandru]]

Backed out changeset ca4d87f2ec7b (Bug 1676657) for causing webrender bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/6d1dbfe63e14949215349672d5dcaf3906e4e2ab
Push with failures, failure log.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47a2e56cc7a6
Port paint phase weight histograms to WebRender r=nical

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/47a2e56cc7a6