1676859 - Wrong mailing list printing output : display name is duplicate into the primary email address.

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Chris GAUDRY [:cmgaudry33]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36

Steps to reproduce:

• Create an address book
• Add a new contact to this address book : set its display name and its primary email
• Create a mailling list into this address book
• Add the previous contact to the mailing list
• Print the mailing list

Actual results:

The contact appears to be "DISPLAY_NAME <DISPLAY_NAMEemail>" instead of "DISPLAY_NAME <email>".

Expected results:

The actual XML output is like this

		<?xml-stylesheet type="text/css" href="chrome://messagebody/content/addressbook/print.css"?>
		<directory>
		<title xmlns="http://www.w3.org/1999/xhtml">Carnet d’adresses</title>
		<GeneratedName>
		My mailing list</GeneratedName>
		<table><tr><td><section><labelrow><label>Display Name: </label><DisplayName>My mailing list</DisplayName></labelrow><labelrow><label>Nickname: </label><NickName>my mailing list</NickName></labelrow></section></td></tr><tr><td><section></section><section><sectiontitle>Description</sectiontitle><Notes>notes</Notes></section><section><sectiontitle>Addresses</sectiontitle><PrimaryEmail>
		TRUMP Donald ( White House ) &lt;TRUMP Donald ( White House )[e-mail]&gt;</PrimaryEmail>
		<PrimaryEmail>
		BIDEN Joe ( White House ) &lt;BIDEN Joe ( White House )[e-mail]&gt;</PrimaryEmail>
		</section></td><td><section></section><section></section></td></tr></table></directory>

It should be like this :

		<?xml version="1.0"?>
		<?xml-stylesheet type="text/css" href="chrome://messagebody/content/addressbook/print.css"?>
		<directory>
		<title xmlns="http://www.w3.org/1999/xhtml">Carnet d’adresses</title>
		<GeneratedName>
		My mailing list</GeneratedName>
		<table><tr><td><section><labelrow><label>Display Name: </label><DisplayName>My mailing list</DisplayName></labelrow><labelrow><label>Nickname: </label><NickName>my mailing list</NickName></labelrow></section></td></tr><tr><td><section></section><section><sectiontitle>Description</sectiontitle><Notes>notes</Notes></section><section><sectiontitle>Addresses</sectiontitle><PrimaryEmail>
		TRUMP Donald ( White House ) &lt;[e-mail]&gt;</PrimaryEmail>
		<PrimaryEmail>
		BIDEN Joe ( White House ) &lt;[e-mail]&gt;</PrimaryEmail>
		</section></td><td><section></section><section></section></td></tr></table></directory>

Comment 1

[Chris GAUDRY [:cmgaudry33]]

Attachment: bug_1676859.diff

This fix can be applied to the daily version.

Comment 2

[Chris GAUDRY [:cmgaudry33]]

This should be fixed in Thunderbird 78 also.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9187366 [details] [diff] [review]
bug_1676859.diff

Review of attachment 9187366 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, yeah that's a bad API. r=mkmelin
(You put the reviewer in the r=, not your own email)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8fabcfa9fc2e
Fix Wrong mailing list printing output : display name is duplicate into the primary email address. r=mkmelin

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9187366 [details] [diff] [review]
bug_1676859.diff

Review of attachment 9187366 [details] [diff] [review]:
-----------------------------------------------------------------

Safe to uplift.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9187366 [details] [diff] [review]
bug_1676859.diff

[Triage Comment]
Approved for beta

Comment 7

[Dave Miller [:justdave]]

Thunderbird 84.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/6c213054d1c4

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9187366 [details] [diff] [review]
bug_1676859.diff

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.5.1:
https://hg.mozilla.org/releases/comm-esr78/rev/ab9928932b58