1676956 - webRequest streamfilter tests are run with in-process extensions only, not oop extensions

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task, P2)

Description

[Rob Wu [:robwu]]

In bug 1649873, the StreamFilter tests were moved from xpcshell-common.ini to xpcshell-remote.ini, because the tests weren't working when e10s is off.

xpcshell-remote.ini is e10s on, OOP webextensions off.
We should run the tests when e10s is on, to more closely match the real-world situation. This can be done by moving the logic to xpcshell-remote.ini.

If we care about running the tests with both oop extensions and in-process extensions (e.g. because we still use in-process extensions on Android until bug 1535365 is fixed), then we have the following options:

• Repeat the tests in xpcshell-remote.ini and xpcshell-e10s.ini
• Add the test to xpcshell-common.ini, but add a skip_if to the add_task in the individual test files.
• Introduce a new test manifest (.ini file) that gets included by both xpcshell-e10s.ini and xpcshell-remote.ini (this is basically the same as xpcshell-common.ini, except not being included by xpcshell.ini).

Comment 1

[Rob Wu [:robwu]]

We just discussed this, and are considering the second option, i.e. moving the tests back to xpcshell-common.ini and then using skip_if in the files themselves. The downside of that is that it is not obvious that the tests are skipped (when looking at test manifests), but the current state of affairs, where tests are not run with our primary supported configuration is much worse.

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1676956 - Run StreamFilter tests with oop extensions too

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e7653247208
Run StreamFilter tests with oop extensions too r=mixedpuppy

Comment 4

[Atila Butkovits]

Backed out for causing failures on test_ext_webRequest_startup.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/24bbee27225215f88023d917d0c502a2c3b4f969

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=BfnxRLaTSvGNqlSvvsbE3g.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cxpcshell%2Ctests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-xpcshell-e10s%2Cx3&revision=a421fd8b98973bcd6569ccc904523105c7282cd6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=324836166&repo=autoland&lineNumber=2601

Comment 5

[Rob Wu [:robwu]]

Going to reland, the failure from comment 4 will be addressed in bug 1683159.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/557c3876e77d
Run StreamFilter tests with oop extensions too r=mixedpuppy

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/557c3876e77d

Comment 8

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9191352 [details]
Bug 1676956 - Run StreamFilter tests with oop extensions too

Beta/Release Uplift Approval Request

• User impact if declined: test only changes necessary to uplift bug 1678734
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: n/a
• List of other uplifts needed: Bug 1678734
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): test only changes
• String changes made/needed: n/a

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9191352 [details]
Bug 1676956 - Run StreamFilter tests with oop extensions too

a=test-only

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa189d71dc3c