remove compat.jsm and other basically unused or unneeded former enigmail modules
Categories
(MailNews Core :: Security: OpenPGP, task)
Tracking
(thunderbird_esr78 wontfix, thunderbird_esr115 wontfix)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
(Blocks 1 open bug)
Details
(Keywords: leave-open)
Attachments
(41 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
This doesn't seem to do anything useful. All the services can be called directly, and the tree stuff is for old versions of Thunderbird.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
Replace EnigmailCompat.generateQI with ChromeUtils.generateQI
find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E 's/EnigmailCompat.generateQI/ChromeUtils.generateQI/g' {} ;
Delete lazy import lines
find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E '/EnigmailCompat: "chrome://openpgp/content/modules/compat.jsm"/d' {} ;
EnigmailCompat.copyFileToMailFolder -> MailServices.copy.CopyFileMessage
+ then manually adjust the arguments
find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E 's/EnigmailCompat.copyFileToMailFolder/MailServices.copy.CopyFileMessage/g' {} ;
EnigmailCompat.getUrlFromUriSpec: move this function to EnigmailFuncs, mail/extensions/openpgp/content/modules/funcs.jsm
find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E 's/EnigmailCompat.getUrlFromUriSpec/EnigmailFuncs.getUrlFromUriSpec/g' {} ;
EnigmailCompat.getExistingFolder -> MailUtils.getExistingFolder
find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E 's/EnigmailCompat.getExistingFolder/MailUtils.getExistingFolder/g' {} ;
getTreeCompatibleFuncs: manually change to operate on the tree and not on the functs (which just wrapped the functions)
Assignee | ||
Comment 3•3 years ago
|
||
FeedUtils had copy of the same functionality. Perhaps the function should be moved somewhere else, but we're not even hooking up the keyserver atm so it's for the moment unused code.
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D111421
Assignee | ||
Comment 5•3 years ago
|
||
Depends on D111425
Assignee | ||
Updated•3 years ago
|
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/9dfed969aa03 remove unused socks5Proxy.jsm. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/bff7b0d79ad4 remove enigmail compat.jsm. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/003725015964 remove xhrUtils.jsm. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/429e8371e786 remove unused mail/extensions/openpgp/content/modules/addrbook.jsm. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/b99806ebe6dc remove unused mail/extensions/openpgp/content/modules/autoSetup.jsm. r=PatrickBrunschwig
Assignee | ||
Comment 7•3 years ago
|
||
Assignee | ||
Comment 8•3 years ago
|
||
Depends on D111544
Assignee | ||
Comment 9•3 years ago
|
||
Depends on D111545
Comment 10•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/170bd65d2093 remove unused mail/extensions/openpgp/content/modules/configBackup.jsm. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/9978d549ed99 remove mail/extensions/openpgp/content/modules/configure.jsm which doesn't do anything. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/1cf448c6e178 remove mail/extensions/openpgp/content/modules/app.jsm. r=PatrickBrunschwig
Assignee | ||
Comment 11•3 years ago
|
||
We're not using anything from the enigmail.properties file, since everything was converted to Fluent.
Inlining the strings now so we know what they were, in case some of them are needed in the future.
Comment 12•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/3cae048e6dfb remove EngimailLocale - mail/extensions/openpgp/content/modules/locale.jsm. r=PatrickBrunschwig
Assignee | ||
Comment 13•3 years ago
|
||
Comment 14•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/41ef5743e159 clean out most of the globals from enigmailCommon.js. r=PatrickBrunschwig
Assignee | ||
Comment 15•3 years ago
|
||
Assignee | ||
Comment 16•3 years ago
|
||
Assignee | ||
Comment 17•3 years ago
|
||
Comment 18•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/f0174708d594 remove EnigmailPrefs. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/d417ebc52419 remove EnigmailTime. r=PatrickBrunschwig
Assignee | ||
Updated•3 years ago
|
Comment 19•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/f5c2785a9c8c remove EngmailOS. r=PatrickBrunschwig
Assignee | ||
Comment 20•3 years ago
|
||
I assume this was used for something more at some point in the past. At the moment, it doesn't appear to do much.
Nothing was every pushed to createdURIs.
For the buggy exchange message, it appears we always just display blank now until we can decrypt. The message that (maybe?) was intended to show, I don't see ever getting accessed.
Assignee | ||
Comment 21•3 years ago
|
||
Comment 22•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/cb7f881249d4 remove EnigmailProtocolHandler. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/9a5cb3c312a4 remove EnigmailRNG (rng.jsm). r=PatrickBrunschwig
Assignee | ||
Comment 23•3 years ago
|
||
Depends on D127939
Assignee | ||
Comment 24•3 years ago
|
||
Depends on D127942
Comment 25•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/5b21121bd4bb remove unused EnigmailDialog.longAlert. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/41c84577b76f remove EnigmailDialog.promptValue. r=PatrickBrunschwig
Assignee | ||
Comment 26•3 years ago
|
||
Remove temp dir handling (temp dir must always exist), and also a few other methods never used anymore.
Assignee | ||
Comment 27•3 years ago
|
||
Assignee | ||
Comment 28•3 years ago
|
||
Assignee | ||
Comment 29•3 years ago
|
||
Comment 30•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/46e8fd271da4 remove EngimailFiles tempdir handling. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/83bf1a13c865 remove EnigmailCommandLine. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/1e6945cf19f2 clean out unused things from EnigmailCore.jsm. r=PatrickBrunschwig
Comment 31•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/2cf27c5269cc remove EnigmailStdlib. r=PatrickBrunschwig
Assignee | ||
Comment 32•2 years ago
|
||
Only use in uncommented code...
Comment 33•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/56660aed4ff5 remove EnigmailAttachment. r=PatrickBrunschwig
Assignee | ||
Comment 34•2 years ago
|
||
This makes the cases that were already in async contexts use normal async/await instead,
and makes some easy-to-convert functions to async as well.
Remaining cases are harder and may each require more work.
Assignee | ||
Comment 35•2 years ago
|
||
It's possible Thunderbird should also have some functionality to remind about expiring keys, but I don't think this would be it.
I don't understand why the recommendation has been to create a new key. Wouldn't it be better to extend the validity?
Assignee | ||
Comment 36•2 years ago
|
||
Comment 37•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/a3092558b8b8 use the Clipboard API instead of EnigmailClipboard. r=PatrickBrunschwig
Comment 38•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/efac1b46face remove unused EnigmailKeyUsability. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/872c8a9e3b02 remove the "easy" cases of capi.sync() calls from openpgp code. r=PatrickBrunschwig
Assignee | ||
Comment 39•2 years ago
|
||
Inlined and slight cleaned up into the one uncommnented (and very broken) use case...
Assignee | ||
Comment 40•2 years ago
|
||
Removing EnigmailFiles required making more functions async, so fixing it rippled a bit.
Making things async changed some timings slightly, which caused some test failures.
I located and fixed a few such problems, where async methods were not properly awaited.
Depends on D133947
Comment 41•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/f1af77be5c05 remove EnigmailSend. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/d7dc20e53bb8 convert EnigmailFiles to using IOUtils. r=PatrickBrunschwig
Assignee | ||
Comment 42•2 years ago
|
||
Removed the whenDoneDB param and made proper use of the functions being async instead.
Fixes some minor buggy behavior as well.
Comment 43•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/ad7f3cd2911e fix KeyLookupHelper async functionality. r=PatrickBrunschwig
Comment 44•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/e116ab678285 remove an old comment. rs=me
Comment 45•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/332dc778c1ce remove pointless comment. rs=me
Assignee | ||
Comment 46•2 years ago
|
||
Comment 47•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/27993795da6f remove unused EnigmailGgp. r=PatrickBrunschwig
Assignee | ||
Comment 48•2 years ago
|
||
Comment 49•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/5d8d79df8659 remove/inline enigmailMsgComposeHelper.js. r=PatrickBrunschwig
Comment 50•2 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #40)
Created attachment 9255584 [details]
Bug 1677088 - convert EnigmailFiles to using IOUtils. r=PatrickBrunschwig
This patch introduced (at least) regression bug 1778509.
Code that previously used binary file reading, and that expected to handle binary files, was converted to use readUTF8.
Assignee | ||
Comment 51•9 months ago
|
||
Assignee | ||
Updated•9 months ago
|
Comment 52•9 months ago
|
||
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/1a1d2a8fd6ff
Remove some dead code in EnigmailMime. r=kaie
Assignee | ||
Comment 53•5 months ago
|
||
Assignee | ||
Comment 54•5 months ago
|
||
Depends on D191956
Assignee | ||
Updated•5 months ago
|
Comment 55•5 months ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/645b84e9cf2e
Remove unused and not fully implemented EnigmailWks. r=kaie
https://hg.mozilla.org/comm-central/rev/4178e8e2e920
Remove EnigmailWksMimeHandler. r=kaie
Comment 56•5 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/2ecf0c43aaab follow-up, remove webKey and wksMimeHandler references. rs=bustage-fix
Assignee | ||
Comment 57•3 months ago
|
||
Assignee | ||
Comment 58•3 months ago
|
||
Depends on D196606
Assignee | ||
Comment 59•3 months ago
|
||
I don't think this ever worked in Thunderbird. Doesn't work now at least. If I set it up so it should work, finishCryptoEncapsulation still errors out so sending fails.
Seems very little point keeping this code around.
Depends on D196607
Assignee | ||
Comment 60•3 months ago
|
||
Used once, in unused code. For a case I'm not sure we should ask the user if we can shoot their foot...
Depends on D196608
Assignee | ||
Comment 61•3 months ago
|
||
Replace with normal alert. No reason OpenPGP code should be all special around this.
More than a few of these would seem like they should have been alerts anyway.
Depends on D196609
Assignee | ||
Comment 62•3 months ago
|
||
grep -rEl "(lazy.)?EnigmailDialog.alert\(.+, .+\)" --exclude-dir=.hg --exclude-dir=suite --exclude-dir=rust --include="*.js" --include="*.jsm" --exclude=".*" . | xargs xargs sed -i -E 's/(lazy.)?EnigmailDialog.alert\(([^,]+), ([^,]+)\)/Services.prompt.alert(\2, null, \3)/g'
- fixup of the multiline ones by hand.
Depends on D196611
Assignee | ||
Comment 63•3 months ago
|
||
Depends on D196612
Comment 64•3 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/18aec38c7877 remove unused EnigmailDialog.alertPref. r=aleca https://hg.mozilla.org/comm-central/rev/b3b0cf32afb2 remove EnigmailDialog.getPromptSvc(). r=aleca
Assignee | ||
Comment 65•3 months ago
|
||
This was faking async.
Updated•3 months ago
|
Comment 66•3 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/866e2f8e68d5 remove EnigmailDialog.confirmBoolPref and last caller: (dysfunctional) encrypt to news. r=kaie
Comment 67•3 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/fad8b09da1ff Remove EnigmailDialog.confirmIntPref. r=aleca
Comment 68•3 months ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #60)
Created attachment 9368983 [details]
Used once, in unused code. For a case I'm not sure we should ask the user if we can shoot their foot...
The dialog is superfluous for MIME-PGP anyway. However, it could become relevant again as soon as Bug 1602481 is implemented again.
Kai Engert what do you think?
Comment 69•3 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/3f6e6309fd54 Remove EnigmailDialog.info. r=aleca
Comment 70•3 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/bb05631954a0 Remove EnigmailDialog.alert. r=aleca
Comment 71•3 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/559471c3c1b0 Remove EnigmailDialog.confirmDlg. r=aleca
Comment 72•3 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/4ab32edc743e Remove EnigmailDialog.filePicker. r=aleca
Comment 73•3 months ago
|
||
(In reply to Alfred Peters [:infofrommozilla] from comment #68)
(In reply to Magnus Melin [:mkmelin] from comment #60)
Created attachment 9368983 [details]
Used once, in unused code. For a case I'm not sure we should ask the user if we can shoot their foot...
The dialog is superfluous for MIME-PGP anyway. However, it could become relevant again as soon as Bug 1602481 is implemented again.
Kai Engert what do you think?
I don't intend to introduce any prompts or interaction for bug 1602481, I don't need this dialog.
Comment 74•3 months ago
|
||
The fix for bug 1602481 further removes old code, including some of the code you have touched here.
Description
•