1891689 - Backup secret key to file from account settings doesn't work

Status: VERIFIED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Magnus Melin [:mkmelin]]

Backup secret key to file from account settings doesn't work.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1891689 - Backup secret key to file from account settings doesn't work. r=kaie

In https://hg.mozilla.org/comm-central/rev/4ab32edc743e I had missed two cases where promptKeyExport2AsciiFilename are now really async.
The dialogs seemingly do the right thing, but it doesn't actually backup if you check for the file.

Added a test so it doesn't regress again.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/65fa22d34e8d
Backup secret key to file from account settings doesn't work. r=kaie

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9396838 [details]
Bug 1891689 - Backup secret key to file from account settings doesn't work. r=kaie

[Approval Request Comment]
Regression caused by (bug #): bug 1677088
User impact if declined: non working feature
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9396838 [details]
Bug 1891689 - Backup secret key to file from account settings doesn't work. r=kaie

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 126.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/5cb53561c8d6

Comment 6

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello!

Is there anything QA can do here to verify that this issue is resolved?
If yes, could you please provide us with STR of what to verify?

Thank you in advance!

Comment 7

[Magnus Melin [:mkmelin]]

Sure, set up an opengpgp key for an account (End-to-End encryption in account settings).
In the account settings of the account, under End-to-End encryption, open the details accordion for the key. Then use the More button and Backup Secret Key to File. Verify the file was created and looks like it should. You could then delete the secret key, and once import it back using the Add-key... button on the same same page

Comment 8

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed on 126.0b2(20240429201016) using macOS 14, Windows 11 and Ubuntu 22.

I was able to create, save to file(locate and view the contents of the file), delete the key and then import it back without any issues.

However I did notice a small issue while importing the key back and will explain it in STR below:

1. Add Key.
2. Import an existing OpenPGP key -> Continue
3. Select file to import... ->select the file -> Open
4. Click Continue and input password. -> Sign In
5. Close

I would expect for the previously imported key to be automatically selected as the End-to-End Encryption method, instead, the None option is automatically selected.
I searched for an existing issue about this but could not find one. Is this the intended behaviour flow?

Comment 9

[Magnus Melin [:mkmelin]]

That seems like a small UI glitch yes. If we didn't have a selected key for the account already, and you created a new one, I agree it should get automatically selected. Please file a bug.