Closed Bug 1677247 Opened 2 months ago Closed 2 months ago

Replace :not(:is(X)) with :not(X) in the codebase

Categories

(Toolkit :: Themes, task)

task

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: ntim, Assigned: ikartikgautam, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(2 files)

:not() has supported selector lists since bug 933562, so :not(:is(X, Y, Z)) can now just be :not(X, Y, Z) for simplicity.

https://searchfox.org/mozilla-central/search?q=%3Anot%28%3Ais&path=&case=false&regexp=false

Summary: Replace :not(:is(X)) with :not(X) → Replace :not(:is(X)) with :not(X) in the codebase
Mentor: emilio
Keywords: good-first-bug
Whiteboard: [lang=css]

Hi,

I would like to take this. Can you please guide me, as it is my first time i am contributing.
Should i replace it from every place listed in the link you have provided above?

Thank You,
Kartik Gautam

Flags: needinfo?(ntim.bugs)

(In reply to Kartik Gautam from comment #1)

Hi,

I would like to take this. Can you please guide me, as it is my first time i am contributing.

Hi Kartik! You can check out https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html for an overview of all you need to make your first patch. Please let me or Emilio know if you have more specific questions.

Should i replace it from every place listed in the link you have provided above?

Everything that's not in the "Test files" category in the link should be replaced.

Flags: needinfo?(ntim.bugs)

Hi,

Can You please help me, i am confused what should be commit message.
Is below message okay ?
hg commit -m "Bug 1677247 Replace :not(:is(X)) with :not(X) in the codebase. r?xyzabc"
And whom should i add as reviewer ?

Thank You,
Kartik Gautam

Flags: needinfo?(ntim.bugs)

(In reply to Kartik Gautam from comment #3)

Hi,

Can You please help me, i am confused what should be commit message.
Is below message okay ?
hg commit -m "Bug 1677247 Replace :not(:is(X)) with :not(X) in the codebase. r?xyzabc"
And whom should i add as reviewer ?

Looks fine, emilio should be a good reviewer for this patch.
Also, most people usually add the dash between the bug number and the first word.

So: hg commit -m "Bug 1677247 - Replace :not(:is(X)) with :not(X) in the codebase. r?emilio"

Flags: needinfo?(ntim.bugs)
Assignee: nobody → ikartikgautam
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/12ead8ec6530
Replace :not(:is(X)) with :not(X) in the codebase. r=emilio
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/99e75de2454e
Followup: reformat downloads.css a bit. DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
See Also: → 1679463
Blocks: 1679452
You need to log in before you can comment on or make changes to this bug.