1677247 - Replace :not(:is(X)) with :not(X) in the codebase

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Tim Nguyen :ntim]

:not() has supported selector lists since bug 933562, so :not(:is(X, Y, Z)) can now just be :not(X, Y, Z) for simplicity.

https://searchfox.org/mozilla-central/search?q=%3Anot%28%3Ais&path=&case=false&regexp=false

Comment 1

[Kartik Gautam]

Hi,

I would like to take this. Can you please guide me, as it is my first time i am contributing.
Should i replace it from every place listed in the link you have provided above?

Thank You,
Kartik Gautam

Comment 2

[Tim Nguyen :ntim]

(In reply to Kartik Gautam from comment #1)

Hi,

I would like to take this. Can you please guide me, as it is my first time i am contributing.

Hi Kartik! You can check out https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html for an overview of all you need to make your first patch. Please let me or Emilio know if you have more specific questions.

Should i replace it from every place listed in the link you have provided above?

Everything that's not in the "Test files" category in the link should be replaced.

Comment 3

[Kartik Gautam]

Hi,

Can You please help me, i am confused what should be commit message.
Is below message okay ?
hg commit -m "Bug 1677247 Replace :not(:is(X)) with :not(X) in the codebase. r?xyzabc"
And whom should i add as reviewer ?

Thank You,
Kartik Gautam

Comment 4

[Tim Nguyen :ntim]

(In reply to Kartik Gautam from comment #3)

Hi,

Can You please help me, i am confused what should be commit message.
Is below message okay ?
hg commit -m "Bug 1677247 Replace :not(:is(X)) with :not(X) in the codebase. r?xyzabc"
And whom should i add as reviewer ?

Looks fine, emilio should be a good reviewer for this patch.
Also, most people usually add the dash between the bug number and the first word.

So: hg commit -m "Bug 1677247 - Replace :not(:is(X)) with :not(X) in the codebase. r?emilio"

Comment 5

[Kartik Gautam]

Attachment: Bug 1677247 - Replace :not(:is(X)) with :not(X) in the codebase. r?emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12ead8ec6530
Replace :not(:is(X)) with :not(X) in the codebase. r=emilio

Comment 7

[Tim Nguyen :ntim]

Attachment: Bug 1677247 - Followup: reformat downloads.css a bit.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e75de2454e
Followup: reformat downloads.css a bit. DONTBUILD

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/12ead8ec6530
https://hg.mozilla.org/mozilla-central/rev/99e75de2454e