1679452 - Replace :not(X):not(Y) with :not(X, Y)

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Tim Nguyen :ntim]

:not(a):not(b):not(c) and :not(a, b, c) are equivalent.

Let's replace them: https://searchfox.org/mozilla-central/search?q=%3Anot%28%5B%5E%5Cs%5C%5C%5D*%29%3Anot%28%5B%5E%5Cs%5C%5C%5D*%29&path=css&case=false&regexp=true

Files to exclude:

• browser/components/downloads/content/downloads.css (doesn't follow the pattern I showed)
• browser/components/newtab/content-src/components/DiscoveryStreamComponents/List/_List.scss
• browser/components/newtab/css/activity-stream-linux.css
• browser/components/newtab/css/activity-stream-mac.css
• browser/components/newtab/css/activity-stream-windows.css
• layout/docs/css-grid-3/Overview.html
• Test files

Comment 1

[Kartik Gautam]

Hi,

I just check the searchfox link you provided, and noticed that the pattern is like this : :not(a):not(b) ,
so are :not(a):not(b) and :not(a, b) equivalent ?

Thank You,
Kartik Gautam

Comment 2

[Tim Nguyen :ntim]

(In reply to Kartik Gautam from comment #1)

Hi,

I just check the searchfox link you provided, and notices that the patter is like this : :not(a):not(b) ,
so are :not(a):not(b) and :not(a, b) equivalent ?

Yes, this also applies for more than 2 items. Also applies when they're not next to each other (selector:not(a)...not(b) is the same as selector...:not(a, b)).

Note that I've added some more files to ignore to the list.

Btw, I haven't included those in the initial link, but could you please update these as well?

• devtools/client/shared/components/Tree.js
• devtools/client/shared/focus.js
• toolkit/components/passwordmgr/NewPasswordModel.jsm
• devtools/client/framework/test/browser_toolbox_options_multiple_tabs.js

Thanks!

Comment 3

[Kartik Gautam]

(In reply to Tim Nguyen :ntim from comment #2)

(In reply to Kartik Gautam from comment #1)

Hi,

I just check the searchfox link you provided, and notices that the patter is like this : :not(a):not(b) ,
so are :not(a):not(b) and :not(a, b) equivalent ?

Yes, this also applies for more than 2 items. Also applies when they're not next to each other (selector:not(a)...not(b) is the same as selector...:not(a, b)).

Note that I've added some more files to ignore to the list.

Btw, I haven't included those in the initial link, but could you please update these as well?

• devtools/client/shared/components/Tree.js
• devtools/client/shared/focus.js
• toolkit/components/passwordmgr/NewPasswordModel.jsm
• devtools/client/framework/test/browser_toolbox_options_multiple_tabs.js

Thanks!

okay sir, please assign it to me, i will take this up.
Thank you again

Comment 4

[Kartik Gautam]

Attachment: Bug 1679452 - Replace :not(X):not(Y) with :not(X, Y) r?ntim

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d559a068da1
Replace :not(X):not(Y) with :not(X, Y) r=ntim

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1d559a068da1