1677402 - Apply theme colors on findbar when header image is used

Status: NEW

(WebExtensions :: Themes, defect, P3)

Description

[juhyt80]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

Setting FF theme with image included.
Manifest rule:

• theme > images > theme_frame

Actual results:

Search box (when pressing Ctrl + F) appeared to be default white.

Expected results:

Search box should be some of these colors if image is included:
(As described here: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme)

toolbar
frame
frame_inactive

If you use only colors - everything working as expected.
This bug was reported to me by addon user.

Comment 1

[juhyt80]

Attachment: Bugged search box screenshot.

Comment 2

[juhyt80]

Attachment: Expected search box.

Comment 3

[Alex Cornestean]

Hello,

I’ve managed to reproduce the issue on the latest Nightly (85.0a1/20201122213806), Beta (84.0b4/20201122152513) and Release (83.0/20201112153044) under Windows 10 Pro and Ubuntu 16.04 LTS.
Applying a theme containing an image will leave the search bar the default color scheme while applying a theme not having an image included will properly set the color scheme to the search bar as well.

Comment 4

[Tomislav Jovanovic :zombie]

Hey Tim, can you please take a look at this?

Comment 5

[Tim Nguyen :ntim]

Could you please add a link to an example affected theme(s) so I can take a look?

Comment 6

[Tim Nguyen :ntim]

Fwiw, you can use the toolbar/toolbar_text + toolbar_field/toolbar_field_text to make your themes work on the findbar.

EDIT: this is wrong, sorry.

Comment 7

[Tim Nguyen :ntim]

This was an intentional decision in bug 1506913 to avoid contrast issues with themes, since most themes will be designed without necessarily checking the findbar. This is problematic with images, since we don't show them on the findbar, so color combinations may not be contrasting enough there.

It is possible to fix this, just with quite a bit of complexity added to the code. Things might change if the findbar is ever redesigned though.

:zombie, is this something your team wants to take on or leave this as a WONTFIX?