Closed Bug 1677421 Opened 4 years ago Closed 3 years ago

Sometimes the profiler doesn't process the captured stacks unless you restart Nightly

Categories

(Core :: Gecko Profiler, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: mayankleoboy1, Unassigned)

References

Details

Attachments

(1 file)

I dont know the correct terminology

  1. Use nightly
  2. Press ctrl+shift+1 to begin a capture
  3. Do the stuff you want to profile
  4. Press ctrl+shift+2
  5. A new tab will open with the URL https://profiler.firefox.com/from-addon/

And thats it. The page never proceeds further than this. In a bug-free mode, the URL "callstack v5" would be appended to the URL, and then the usual processing would take place.
If I try to close nightly at this stage, nightly process keeps on running.
I am unable to capture profiles until i restart nightly.

This is an intermittent bug.

By "that's it", do you mean that the tab stays completely empty?

I think I see something similar sometimes, but restarting the profiler (without restarting Nightly itself) usually works for me.

It will be difficult to debug. We should add more diagnostic information in the js console to try and catch what goes wrong...

Greg, you know more about the interaction between the Gecko Profiler and the receiving profiler.firefox.com tab, would you have any ideas or suggestions?

Severity: -- → S3
Flags: needinfo?(gtatum)
Priority: -- → P2

tab doesnt stay "blank". It shows the page animation of the horizontal lines fading in-and-out. The page doesnt progress beyond that, though.

(In reply to Mayank Bansal from comment #0)

If I try to close nightly at this stage, nightly process keeps on running.

This seems similar to what I was describing in bug 1675068 comment 1.

See Also: → 1675068

The frame script injection is very naive, and we do not really surface up any information about what's going on in this process. I'm hesitant to mess with the frame script to add new features, but we should explore Bug 1625309, and then see if we can use more of a dialog between the Gecko Profiler an the front-end so that we know the status of things. Right now errors are really hard to debug.

Flags: needinfo?(gtatum)

I filed Bug 1677490 for better diagnostics in this area.

This file handles the injection, and the only way I know to debug it at this point is to do it locally on the machine:

https://searchfox.org/mozilla-central/source/devtools/client/performance-new/frame-script.js

Mayank: Could you please provide your OS information?

Attached file about:support

havent reproduced this for some time. Closing as fixed.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: