1677647 - [Link] Button on Filelink info bar fails to open up Filelink section in Options

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect, P3)

Description

[Thomas D. (:thomas8)]

STR

1. Compose message
2. Attach large attachment > 5 MB
3. Choose [Link] button on yellow Filelink info bar which appears

Actual Result

• Options tab opens on General section
• Does not open Composition > Attachments section where Filelink can be set up
• For regular users, this renders the entire Filelink feature de facto unavailable as they won't know where to start with it (hence S2).

Expected Result

• Options tab should be opened directly on the Composition > Attachments section which includes the settings for Filelink

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1677647_Filelink-Pref-link-not-working-0.patch

Comment 2

[Thomas D. (:thomas8)]

Comment on attachment 9188259 [details] [diff] [review]
Bug-1677647_Filelink-Pref-link-not-working-0.patch

Review of attachment 9188259 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Kushil, this looks promising! ;-)

If it wasn't for protocol, I could have reviewed this one-liner, but alas, it's just f+ from me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/753a8a4d305f
Fix Button on Filelink info bar fails to open up Filelink section in Options. r=mkmelin

Comment 4

[Khushil Mistry [:khushil324]]

Comment on attachment 9188259 [details] [diff] [review]
Bug-1677647_Filelink-Pref-link-not-working-0.patch

[Approval Request Comment]
Regression caused by (bug #): 1565789
User impact if declined: Opening the Options tab from Filelink info bar will not lead to the right section.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9188259 [details] [diff] [review]
Bug-1677647_Filelink-Pref-link-not-working-0.patch

[Triage Comment]
Approved for beta

Comment 6

[Dave Miller [:justdave]]

Thunderbird 84.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/0e5b11e1f941

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9188259 [details] [diff] [review]
Bug-1677647_Filelink-Pref-link-not-working-0.patch

[Triage Comment]
Approved for esr78

Comment 8

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-esr78/rev/35e7bca650a689c849e9d2f061903eaa9aa29c88

Comment 9

[Kai Engert [:KaiE:]]

78.5.1