1677718 - Disable the AppCache API on release

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P3)

Description

[Anne (:annevk)]

Out of caution we should probably wait with this until Chrome has completely removed support, which per https://web.dev/appcache-removal/ is in April 2021.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Complete removal in chrome is now listed as Chrome 93 (estimated October 2021)

Comment 2

[Chris Mills [:cmills]]

I think we've already got this marked as completely removed in MDN ;-)

Adding DDN in case there is anything else to do.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

The API is not removed yet - but without the backing storage it does not provide offline cache capabilities.
This bug is about removing the API too.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1677718 - Disable the AppCache API on release r=#necko

This API has been disabled on nightly and early beta for a long time.
We have kept the API available in release in order to avoid
triggering any bugs in webapps that assume the API is there, but the
cache backing has been removed a few years back.

Considering this has also been removed in Chrome, it's quite safe
to disable and completely remove it from Firefox.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

We should also aim to remove all of the leftovers of this API in Fx115 to make maintenance of ESR a bit easier.

https://searchfox.org/mozilla-central/search?q=offlineresourcelist&path=&case=false&regexp=false
https://searchfox.org/mozilla-central/search?q=appcache&path=&case=false&regexp=false
https://searchfox.org/mozilla-central/search?q=applicationcache&path=&case=false&regexp=false

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1677718 - Completely remove AppCache API implementation r=#necko

Depends on D179337

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1cfc37a01b3
Disable the AppCache API on release
https://hg.mozilla.org/integration/autoland/rev/2b6b58a6fe2f
Completely remove AppCache API implementation r=necko-reviewers,emilio,jesup

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d1cfc37a01b3
https://hg.mozilla.org/mozilla-central/rev/2b6b58a6fe2f

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for causing appcache wpt failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=860d4ed91dffa9234ae180191d7c1a5e07b21520&test_paths=%2Ffetch%2Fmetadata%2Fgenerated&selectedTaskRun=fJLXIOU6Soa1AwMD-0XkuA.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=417702270&repo=mozilla-central
• https://treeherder.mozilla.org/logviewer?job_id=417703572&repo=mozilla-central

Backout link: https://hg.mozilla.org/integration/autoland/rev/429de46507f9fe5d2129a9fa90ac5968e26b233e

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5b7a8fa5f41
Disable the AppCache API on release

Comment 12

[Serban Stanca [:SerbanS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/429de46507f9fe5d2129a9fa90ac5968e26b233e

Comment 13

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1677718 - Disable appcache WPT r=#necko

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14184d0ac48f
Disable appcache WPT

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a5b7a8fa5f41
https://hg.mozilla.org/mozilla-central/rev/14184d0ac48f

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ab03ad25178
Completely remove AppCache API implementation r=necko-reviewers,emilio,jesup

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5ab03ad25178

Comment 18

[Hamish Willee]

FF115 docs work for this tracked in https://github.com/mdn/content/issues/27176. Effectively nothing much done, as most of the needed cleanup was done in FF84, and few if any developers will be impacted by this removal.