1677812 - Thunderbird appears to be attempting to access the Firefox remote settings server rather than the Thunderbird one

Status: RESOLVED FIXED

(Thunderbird :: Search, defect, P1)

Description

[Mark Banner (:standard8)]

I was just investigating an issue with Thunderbird and the search configuration, and noticed that Thunderbird is attempting to access:

https://firefox.settings.services.mozilla.com/v1/buckets/monitor/collections/changes/records?collection=url-classifier-skip-urls&bucket=thunderbird

This should be using https://thunderbird-settings.thunderbird.net/v1/...

Comment 1

[Mark Banner (:standard8)]

This only affects Thunderbird beta currently (it will affect release as well when we get that far).

The issue is here:

https://searchfox.org/mozilla-central/rev/277ab3925eae21b419167a34624ec0ab518d0c94/services/settings/Utils.jsm#57-65

The hardcoding of Firefox there is breaking Thunderbird's setup.

Mathieu, could we add an additional check for Thunderbird there and fallback to Thunderbird's server?

Comment 2

[Wayne Mery (:wsmwk)]

a regression?

Comment 3

[Magnus Melin [:mkmelin]]

I see there's a services.settings.server pref pointing to https://firefox.settings.services.mozilla.com/v1 so I suppose Utils.jsm should use that, and Thunderbird would set it's override to point to the Thunderbird server.

Comment 4

[Mark Banner (:standard8)]

This should probably be fixed for 91, otherwise TB will be using the wrong server.

Comment 5

[Magnus Melin [:mkmelin]]

Thunderbird is already set to use the pref: https://searchfox.org/comm-central/rev/024d50ad6d85b1d810a47ddf32e31e0c48e21621/mail/app/profile/all-thunderbird.js#174

Martin, can you do m-c patch to change this to use the pref: https://searchfox.org/comm-central/rev/024d50ad6d85b1d810a47ddf32e31e0c48e21621/mozilla/services/settings/Utils.jsm#63

Comment 6

[Martin Giger [:freaktechnik]]

Attachment: Bug 1677812 - Don't force Firefox settings server for Thunderbird. r=leplatrem

Comment 7

[Martin Giger [:freaktechnik]]

Just to relay information from phabricator back here: the long-term plan is to use a build constant to set the URL instead of hard coding it. So the pref will probably be replaced with that constant eventually.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa7523ddc281
Don't force Firefox settings server for Thunderbird. r=leplatrem

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/aa7523ddc281

Comment 10

[Geoff Lankow (:darktrojan)]

This bug has a target milestone of 91 so I'm setting the status-thunderbird91 flag to fixed.