1678054 - Enable bookmark toolbar upon bookmark import by default

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement)

Description

[Romain Testard [:RT]]

Omnibus proved that the Shirley features improve user engagement while not regressing activation or retention:
https://docs.google.com/document/d/16JEiQ_8XSk3nBs9qcwMZC-76m4nttb1YRKwc6Xhf1xE/edit#heading=h.dywl2xu8cafc

We want to enable the Shirley features to all users. This bug in particular tracks enablement of the bookmark toolbar upon successful bookmark import action.

Acceptance criteria:

• set browser.migrate.showBookmarksToolbarAfterMigration to true

Comment 1

[Romain Testard [:RT]]

The intention is to ship this with 84, an uplift will therefore be required.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1678054 - Enable showing the bookmarks toolbar after migration for all users.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0c5f3119314
Enable showing the bookmarks toolbar after migration for all users. r=Gijs

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d0c5f311931401e1f7d34c7ca746a036d6f75b05

Comment 6

[Romain Testard [:RT]]

Can this be uplifted to 84 so we align all previous Shirley features to ship with 84 ?

Comment 7

[:Gijs (he/him)]

Comment on attachment 9188657 [details]
Bug 1678054 - Enable showing the bookmarks toolbar after migration for all users.

Beta/Release Uplift Approval Request

• User impact if declined: Bookmarks toolbar doesn't show automatically even if bookmarks are imported there
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: This is just a pref flip so it shouldn't need additional testing. Testing happened in bug 1658541
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a pref flip which we've already verified via Shirley
• String changes made/needed: no

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9188657 [details]
Bug 1678054 - Enable showing the bookmarks toolbar after migration for all users.

Approved for 84.0b8.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1be7489c1598

Comment 10

[Daniel Cicas [:dcicas], Release QA]

Hello,

Verified on Fx 84.0b8 and 85.0a1 on Win 10, macOS 11 and Ubuntu 18.04.