Closed Bug 1678390 Opened 2 years ago Closed 11 months ago

Prevent Picture-in-Picture windows from opening on top of one another

Categories

(Toolkit :: Picture-in-Picture, enhancement, P2)

Product:
Toolkit
Component:
Picture-in-Picture
Platform:
Desktop
All
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: whjones526, Assigned: whjones526)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file)

Bug 1678390: Prevent Picture-in-Picture windows from opening on top of one another r=mconley!
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Assignee: nobody → whjones526
Blocks: videopip, 1666299
Status: UNCONFIRMED → ASSIGNED
Component: Untriaged → Video/Audio Controls
Ever confirmed: true
OS: Unspecified → All
Product: Firefox → Toolkit
Hardware: Unspecified → Desktop
Blocks: 1662870
No longer blocks: 1666299
Blocks: 1685549
No longer blocks: 1662870
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18d93890f0ad
Prevent Picture-in-Picture windows from opening on top of one another r=mconley

Backed out changeset 18d93890f0ad (bug 1678390) for browser_resizeVideo.js failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=48913f408b556755f3195883a689e0b60ef356ed&searchStr=windows%2C10%2Cx64%2Copt%2Cmochitests%2Ctest-windows10-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc6&tochange=7f4b13372745fd80ed3df5df2770440494917934&selectedTaskRun=WunBWtgWQUCuGWqzXRY5rA.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/7f4b13372745fd80ed3df5df2770440494917934

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327152518&repo=autoland&lineNumber=3394

[task 2021-01-19T15:06:45.216Z] 15:06:45     INFO - TEST-START | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js
[task 2021-01-19T15:06:45.673Z] 15:06:45     INFO - TEST-INFO | started process screenshot
[task 2021-01-19T15:06:45.760Z] 15:06:45     INFO - TEST-INFO | screenshot: exit 0
[task 2021-01-19T15:06:45.760Z] 15:06:45     INFO - Buffered messages logged at 15:06:45
[task 2021-01-19T15:06:45.760Z] 15:06:45     INFO - Entering test bound 
[task 2021-01-19T15:06:45.761Z] 15:06:45     INFO - Testing with-controls case.
[task 2021-01-19T15:06:45.761Z] 15:06:45     INFO - must wait for focus
[task 2021-01-19T15:06:45.761Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Got PiP window. - [object Window] == true - 
[task 2021-01-19T15:06:45.762Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Original aspect ratio is 16:9 - 177 == 177 - 
[task 2021-01-19T15:06:45.762Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Resized aspect ratio is 4:3 - 133 == 133 - 
[task 2021-01-19T15:06:45.763Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Resized video has smaller width - 320 < 427 - 
[task 2021-01-19T15:06:45.763Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Resized video is the same vertically - 240 == 240 - 
[task 2021-01-19T15:06:45.763Z] 15:06:45     INFO - Buffered messages finished
[task 2021-01-19T15:06:45.764Z] 15:06:45     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video ends at the same screen X position (within 1 pixel) - 107 < 2 - JS frame :: chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_resizeVideo.js :: checkPosition :: line 69
[task 2021-01-19T15:06:45.764Z] 15:06:45     INFO - Stack trace:
[task 2021-01-19T15:06:45.764Z] 15:06:45     INFO - chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_resizeVideo.js:checkPosition:69
[task 2021-01-19T15:06:45.764Z] 15:06:45     INFO - chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_resizeVideo.js:testVideo:124
[task 2021-01-19T15:06:45.764Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video ends at the same screen Y position - 304 == 304 - 
[task 2021-01-19T15:06:45.765Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Vertical aspect ratio is 1:2 - 56 == 56 - 
[task 2021-01-19T15:06:45.765Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Vertical video width shrunk - 136 < 320 - 
[task 2021-01-19T15:06:45.765Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Vertical video height matches previous height - 240 == 240 - 
[task 2021-01-19T15:06:45.765Z] 15:06:45     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-01-19T15:06:45.766Z] 15:06:45     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video ends at the same screen X position (within 1 pixel) - 184 < 2 - JS frame :: chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_resizeVideo.js :: checkPosition :: line 69
[task 2021-01-19T15:06:45.766Z] 15:06:45     INFO - Stack trace:
[task 2021-01-19T15:06:45.766Z] 15:06:45     INFO - chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_resizeVideo.js:checkPosition:69
[task 2021-01-19T15:06:45.766Z] 15:06:45     INFO - chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_resizeVideo.js:testVideo:165
[task 2021-01-19T15:06:45.766Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video ends at the same screen Y position - 304 == 304 - 
[task 2021-01-19T15:06:45.766Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Restored aspect ratio is still 16:9 - 177 == 177 - 
[task 2021-01-19T15:06:45.766Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Restored video has its original width - 0 < 2 - 
[task 2021-01-19T15:06:45.767Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Restored video has its original height - 240 == 240 - 
[task 2021-01-19T15:06:45.767Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video ends at the same screen X position (within 1 pixel) - 0 < 2 - 
[task 2021-01-19T15:06:45.767Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video ends at the same screen Y position - 304 == 304 - 
[task 2021-01-19T15:06:45.767Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Got PiP window. - [object Window] == true - 
[task 2021-01-19T15:06:45.767Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Original aspect ratio is 16:9 - 177 == 177 - 
[task 2021-01-19T15:06:45.786Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Resized aspect ratio is 4:3 - 133 == 133 - 
[task 2021-01-19T15:06:45.786Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Resized video has smaller width - 320 < 427 - 
[task 2021-01-19T15:06:45.786Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Resized video is the same vertically - 240 == 240 - 
[task 2021-01-19T15:06:45.786Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video is still in the same X position - 0 == 0 - 
[task 2021-01-19T15:06:45.786Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video is still in the same Y position - 0 == 0 - 
[task 2021-01-19T15:06:45.815Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Vertical aspect ratio is 1:2 - 56 == 56 - 
[task 2021-01-19T15:06:45.815Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Vertical video width shrunk - 136 < 320 - 
[task 2021-01-19T15:06:45.815Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Vertical video height matches previous height - 240 == 240 - 
[task 2021-01-19T15:06:45.815Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video is still in the same X position - 0 == 0 - 
[task 2021-01-19T15:06:45.815Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video is still in the same Y position - 0 == 0 - 
[task 2021-01-19T15:06:45.853Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Restored aspect ratio is still 16:9 - 177 == 177 - 
[task 2021-01-19T15:06:45.853Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Restored video has its original width - 0 < 2 - 
[task 2021-01-19T15:06:45.853Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | Restored video has its original height - 240 == 240 - 
[task 2021-01-19T15:06:45.853Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video is still in the same X position - 0 == 0 - 
[task 2021-01-19T15:06:45.854Z] 15:06:45     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_resizeVideo.js | New video is still in the same Y position - 0 == 0 - 
[task 2021-01-19T15:06:45.875Z] 15:06:45     INFO - Testing no-controls case.
...
Flags: needinfo?(whjones526)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:whjones526, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(whjones526)
Component: Video/Audio Controls → Picture-in-Picture
Version: Firefox 84 → Trunk
Severity: -- → S4
Priority: -- → P2
Assignee: whjones526 → nobody
Status: ASSIGNED → NEW

Whatever fragility existed for the patch for tests appears to have vanished: https://treeherder.mozilla.org/jobs?repo=try&revision=b646196b2702546ae902e727d755b5ace45c0520

I'm going to clean up some formatting and try to land this.

Flags: needinfo?(whjones526)
Assignee: nobody → whjones526
Attachment #9189347 - Attachment description: Bug 1678390: Prevent Picture-in-Picture windows from opening on top of one another r=mconley → Bug 1678390: Prevent Picture-in-Picture windows from opening on top of one another r=mconley!
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec0089ae2dc0
Prevent Picture-in-Picture windows from opening on top of one another r=mconley

https://hg.mozilla.org/mozilla-central/rev/ec0089ae2dc0

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.