Closed Bug 1678455 Opened 2 years ago Closed 2 years ago

"WebDriver:ElementClick" on links with targets other than "_blank" can cause page load timeout errors

Categories

(Remote Protocol :: Marionette, defect, P1)

Product:
Remote Protocol
Component:
Marionette
Version:
Default
Type:
defect

Tracking

(Fission Milestone:M7, firefox85 fixed)

Status:
RESOLVED FIXED
Milestone:
85 Branch
Project Flags:
Fission Milestone M7
Tracking Flags:
Tracking Status
firefox85 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

(Keywords: hang, Whiteboard: [marionette-fission-mvp], [wptsync upstream])

Attachments

(2 files)

Bug 1678455 - [wdspec] Add target navigation tests for Element Click.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1678455 - [marionette] Add isLoadEventExpected checks for link targets.
47 bytes, text/x-phabricator-request
Details | Review

While writing tests for bug 1674329 I noticed that using "WebDriver:ElementClick" to click on links with different target values like "_top", "_parent", "_self" can fail, and causing a page load timeout error.

To be better equipped for bug 1674329 I will get this fixed first.

Marking bug as marionette-fission-mvp because the broken behavior is blocking my work on bug 1674329.

Whiteboard: [marionette-fission-mvp]

Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7).

Fission Milestone: --- → M7
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38a53d22dd4e
[wdspec] Add target navigation tests for Element Click. r=webdriver-reviewers,jgraham,maja_zf
https://hg.mozilla.org/integration/autoland/rev/f3c67028d935
[marionette] Add isLoadEventExpected checks for link targets. r=marionette-reviewers,maja_zf
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26699 for changes under testing/web-platform/tests
Whiteboard: [marionette-fission-mvp] → [marionette-fission-mvp], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/38a53d22dd4e
https://hg.mozilla.org/mozilla-central/rev/f3c67028d935

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #6)

Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/26699 for changes under
testing/web-platform/tests

James, can you please check why that PR doesn't get merged? Thanks.

Flags: needinfo?(james)
Upstream PR merged by moz-wptsync-bot
Flags: needinfo?(james)
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.